Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase android onboarding study to 50% for release channel #1286

Merged
merged 5 commits into from
Dec 26, 2024
Merged

Increase android onboarding study to 50% for release channel #1286

merged 5 commits into from
Dec 26, 2024

Conversation

deeppandya
Copy link
Contributor

Resolves #1285

@deeppandya deeppandya self-assigned this Dec 20, 2024
@deeppandya deeppandya requested a review from a team as a code owner December 20, 2024 18:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1286.
    Android: Set the command line to --variations-pr=1286 in debug menu, restart the browser.
    iOS: Set Variations PR to 1286 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1286@0a5917fc86c43d5b7e997d33aeab17ebdd7f7078
Uploaded Thu, 26 Dec 2024 17:53:33 GMT
PR commit 161f5c5
Base commit b4fcbac
Merge commit 0a5917f
Serial number 3f685b29c0522fa96f29b420403b9da1

@deeppandya deeppandya changed the title Increase android onboarding study to 50% Increase android onboarding study to 50% for release channel Dec 20, 2024
@deeppandya deeppandya changed the base branch from main to add_android_onboarding_study December 20, 2024 18:15
Base automatically changed from add_android_onboarding_study to main December 23, 2024 17:50
kjozwiak
kjozwiak approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved 👍 @deeppandya mind fixing the merge conflict?

@kjozwiak kjozwiak self-requested a review December 26, 2024 17:55
kjozwiak
kjozwiak approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTam 👍

@kjozwiak kjozwiak added this pull request to the merge queue Dec 26, 2024
Merged via the queue into main with commit 1d8e6f2 Dec 26, 2024
6 checks passed
@kjozwiak kjozwiak deleted the increase_release_weight_50_android_onboarding_study branch December 26, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase android onboarding study to 50%
2 participants
@deeppandya @kjozwiak