Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Shred on iOS all channels #1261

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Enable Shred on iOS all channels #1261

merged 1 commit into from
Nov 18, 2024

Conversation

StephenHeaps
Copy link
Contributor

Fixes #1260

Enabled for Chromium 130.* which released with v1.71 on iOS to not enable for existing releases which included some Shred code behind the feature flag(s).

@StephenHeaps StephenHeaps self-assigned this Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1261.
    Android: Set the command line to --variations-pr=1261 in debug menu, restart the browser.
    iOS: Set Variations PR to 1261 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1261@6b71c09eab99c95d635c07a36da4f2b91daf7434
Uploaded Tue, 12 Nov 2024 21:57:41 GMT
PR commit 0124217
Base commit 06b678a
Merge commit 6b71c09
Serial number 776e7e3779c70e81fcfa7d75276a8bc3

@StephenHeaps StephenHeaps marked this pull request as ready for review November 14, 2024 21:33
@StephenHeaps StephenHeaps requested a review from a team as a code owner November 14, 2024 21:33
@kjozwiak
Copy link
Member

kjozwiak commented Nov 18, 2024

iOS verification(s):

Release - BraveShredFeatureStudy:Enabled (Mobile/Phone)

Verification PASSED on iPhone 11 running iOS 18.1 using the following build(s):

Brave | 1.71.125 Chromium: 130.0.6723.116 (Official Build) stable (64-bit) 
--- | ---
Revision | 192628478ccb...
OS | iOS
  • launched 1.71.118 Chromium: 130.0.6723.70
  • set Variations PR to 1261 via BraveCore Switches under the QA Developer Options
  • once Variations PR has been set, restarted 1.71.118 Chromium: 130.0.6723.70
  • restarted 1.71.118 Chromium: 130.0.6723.70 once more
  • ensured that pull/1261@6b71c09eab99c95d635c07a36da4f2b91daf7434 via brave://version under Active variations
  • ensured that BraveShredFeatureStudy:Enabled via brave://version
  • ensured that the Shred feature is enabled/visible via the shields panel
  • ensured that the Shred feature is enabled/visible long tapping the tabs icon
Example Example Example Example Example Example Example
IMG_0646 IMG_0647 IMG_0648 IMG_0649 IMG_0650 IMG_0651 IMG_0652

Release - BraveShredFeatureStudy:Enabled (Tablet)

Verification PASSED on iPad Air (3rd Gen) running iOS 18.1 using the following build(s):

Brave | 1.71.125 Chromium: 130.0.6723.116 (Official Build) stable (64-bit) 
--- | ---
Revision | 192628478ccb...
OS | iOS
  • launched 1.71.118 Chromium: 130.0.6723.70
  • set Variations PR to 1261 via BraveCore Switches under the QA Developer Options
  • once Variations PR has been set, restarted 1.71.118 Chromium: 130.0.6723.70
  • restarted 1.71.118 Chromium: 130.0.6723.70 once more
  • ensured that pull/1261@6b71c09eab99c95d635c07a36da4f2b91daf7434 via brave://version under Active variations
  • ensured that BraveShredFeatureStudy:Enabled via brave://version
  • ensured that the Shred feature is enabled/visible via the shields panel
  • ensured that the Shred feature is enabled/visible long tapping the tabs icon
Example Example Example Example Example Example Example
IMG_0488 IMG_0489 IMG_0490 IMG_0491 IMG_0492 IMG_0493 IMG_0494

Release - BraveShredFeatureStudy not used - C130 min_version not met (Mobile/Phone)

Verification PASSED on iPhone 11 running iOS 18.1 using the following build(s):

Brave | 1.70.133 Chromium: 129.0.6668.100 (Official Build) stable (64-bit) 
--- | ---
Revision | 53596529e7d7...
OS | iOS
  • launched 1.71.118 Chromium: 130.0.6723.70
  • set Variations PR to 1261 via BraveCore Switches under the QA Developer Options
  • once Variations PR has been set, restarted 1.71.118 Chromium: 130.0.6723.70
  • restarted 1.71.118 Chromium: 130.0.6723.70 once more
  • ensured that pull/1261@6b71c09eab99c95d635c07a36da4f2b91daf7434 via brave://version under Active variations
  • ensured that BraveShredFeatureStudy is not being listed/used under brave://version
  • ensured that the Shred feature is NOT visible via the shields panel
  • ensured that the Shred feature is NOT long tapping the tabs icon
Example Example Example Example Example
IMG_0653 IMG_0654 IMG_0655 IMG_0656 IMG_0657

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production/main approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 6b924cc Nov 18, 2024
7 checks passed
@kjozwiak kjozwiak deleted the enable-shred-ios branch November 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Shred on iOS
2 participants