Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BraveRoundTimeStamps (5% Release) #1215

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Sep 24, 2024

Resolves #1214

Nightly & Beta: 100%
Release: 5%

Disabling the feature just returns the code to the upstream state, so it's relatively safe.
Just to be sure let's start with 5% now and go to 100% the new day.

@atuchin-m atuchin-m self-assigned this Sep 24, 2024
@atuchin-m atuchin-m requested a review from a team as a code owner September 24, 2024 09:55
Copy link
Contributor

github-actions bot commented Sep 24, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1215.
    Android: Set the command line to --variations-pr=1215 in debug menu, restart the browser.
    iOS: Set Variations PR to 1215 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

Parameter Value
Version pull/1215@259040b416c2bfec86558b134985e10ddb6c8aae
Uploaded Tue, 24 Sep 2024 09:59:33 GMT
PR commit d374499
Base commit e7bfa3e
Merge commit 259040b
Serial number 74c79afedd051b00121cacd9df78d3c7

@atuchin-m atuchin-m force-pushed the disable-BraveRoundTimeStamps-release-5% branch from 03d777e to d374499 Compare September 24, 2024 09:58
@kjozwiak
Copy link
Member

kjozwiak commented Oct 8, 2024

Windows x64 verification(s):

Release - BraveRoundTimeStampsReleaseStudy:Default

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.70.123 Chromium: 129.0.6668.89 (Official Build) (64-bit)
-- | --
Revision | 7c1bbf03546a64d969d010808e4f5c99fdf343bb
OS | Windows 11 Version 23H2 (Build 22631.4249)
  • launched/re-launched 1.70.123 Chromium: 129.0.6668.89 using brave.exe --enable-logging=stderr --variations-pr=1215
  • ensured that pull/1215@259040b416c2bfec86558b134985e10ddb6c8aae via brave://version under Active variations
  • ensured that BraveRoundTimeStampsReleaseStudy:Default via brave://version
  • opened https://open.spotify.com and played a really long playlist and switched to a different active tab
  • let https://open.spotify.com run in the background for ~30min and noticed the Memory footprint increase to 11.3 GB
  • switched over to https://open.spotify.com when the Memory footprint was at 11.3 GB and the tab crashed
Example Example Example
reproCrash1 reproCrash2 reproCrash3

BETA - BraveWebViewRoundedCornersStudy:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.71.109 Chromium: 129.0.6668.89 (Official Build) beta (64-bit)
-- | --
Revision | 538f203fb4c3449f0684dbabd4ef6e777c4e4a3b
OS | Windows 11 Version 23H2 (Build 22631.4249)
  • launched/re-launched 1.71.109 Chromium: 129.0.6668.89 using brave.exe --enable-logging=stderr --variations-pr=1215
  • ensured that pull/1215@259040b416c2bfec86558b134985e10ddb6c8aae via brave://version under Active variations
  • ensured that BraveWebViewRoundedCornersStudy:Enabled via brave://version
  • opened https://open.spotify.com and played a really long playlist and switched to a different active tab
  • let https://open.spotify.com run in the background for ~30min and the Memory footprint didn't increase past 250MB
  • waited another ~30mins and started switching between https://open.spotify.com and a few other tabs without crashing
Example Example Example
image image image

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into main/production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on BETA via 1.71.x as per #1215 (comment).

@kjozwiak kjozwiak added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 47fe5b9 Oct 8, 2024
7 checks passed
@kjozwiak kjozwiak deleted the disable-BraveRoundTimeStamps-release-5% branch October 8, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable BraveRoundTimeStamps to fix Spotify crashes
2 participants