Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Serg to alert about GPU related features changes via finch #1196

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Adds Serg to alert about GPU related features changes via finch #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@ module.exports = {
'MetricsClearLogsOnClonedInstall',
],

gpuRelatedFeatures: [
'DefaultANGLEVulkan',
'DefaultPassthroughCommandDecoder',
'EnableDrDcVulkan',
'Vulkan',
'VulkanFromANGLE',
'VulkanV2',
'VulkanVMALargeHeapBlockSizeExperiment',
],

// Add your slack ID to get notifications about new kill switches.
// To retrive it use Slack profile => Copy Member ID.
killSwitchNotificationIds: [
Expand All @@ -32,4 +42,7 @@ module.exports = {
'U02DG0ATML3', // @matuchin
'UE87NRK2A', // @iefremov
],
gpuRelatedNotificationIds: [
'U0D73ULKD', // @serg
],
};
16 changes: 16 additions & 0 deletions src/core/summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ export function summaryToJson(
const output = new MrkdwnMessage();
let hasKillSwitchImportantUpdate = false;
let hasBadStudies = false;
let gpuRelatedFeaturesDetected = false;

// From the highest to the lowest priority:
const priorityList = Object.values(StudyPriority)
Expand All @@ -292,6 +293,12 @@ export function summaryToJson(
);
itemList.sort((a, b) => a.action - b.action);
for (const e of itemList) {
for (const f of e.affectedFeatures) {
if (config.gpuRelatedFeatures.includes(f)) {
gpuRelatedFeaturesDetected = true;
break;
}
}
hasKillSwitchImportantUpdate ||= e.isKillSwitchImportantUpdate();
hasBadStudies ||= e.hasBadStudies;
const block = new TextBlock(e.actionToText());
Expand Down Expand Up @@ -328,6 +335,15 @@ export function summaryToJson(
}
if (output.toString() === '') return undefined;

if (gpuRelatedFeaturesDetected) {
output.addBlockToTop(
new TextBlock(
'GPU related changes detected, cc ' +
config.gpuRelatedNotificationIds.map((i) => `<@${i}>`).join(),
),
);
}

if (hasKillSwitchImportantUpdate) {
output.addBlockToTop(
new TextBlock(
Expand Down