Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support merge queue in main branch. #1138

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Support merge queue in main branch. #1138

merged 1 commit into from
Jul 24, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 24, 2024 •
edited
Loading

These are required fixes to enable the merge queue in some minimal form. Tested in staging branch here: #1136

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1138.
    Android: Set the command line to --variations-pr=1138 in debug menu, restart the browser.
    iOS: Set Variations PR to 1138 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

  • Version: pull/1138@b67506ce48b7736196156ebb910b5c42cae6b0e2
  • Uploaded: 2024-07-24T12:47:34.664Z
  • Serial Number: 0fb7c34b0477ac74c7a87b418c357252

@goodov goodov force-pushed the support-merge-queue branch from b67506c to 2ff4a6a Compare July 24, 2024 12:50
goodov
goodov commented Jul 24, 2024
View reviewed changes
.github/workflows/test-src.yml
@@ -2,8 +2,7 @@ name: Tracker&Griffin tests

on:
pull_request:
branches: [main, production]
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed unnecessary triggers and filters.

@goodov goodov marked this pull request as ready for review July 24, 2024 12:53
@goodov goodov requested a review from mihaiplesa July 24, 2024 12:54
@goodov goodov merged commit d493ec3 into main Jul 24, 2024
7 checks passed
@goodov goodov deleted the support-merge-queue branch July 24, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa mihaiplesa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodov @mihaiplesa