Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest V2 feature 50% => 100% on Release #1131

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Manifest V2 feature 50% => 100% on Release #1131

merged 1 commit into from
Jul 23, 2024

Conversation

ShivanKaul
Copy link
Collaborator

No description provided.

@ShivanKaul ShivanKaul requested a review from a team as a code owner July 22, 2024 22:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1131.
    Android: Set the command line to --variations-pr=1131 in debug menu, restart the browser.
    iOS: Set Variations PR to 1131 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

  • Version: pull/1131@909dacd2203b705eb89a585807a8406a15bfa226
  • Uploaded: 2024-07-22T22:45:59.117Z
  • Serial Number: 66b18bc37280d58f1d60ef0c9a52cc1d

kjozwiak
kjozwiak approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging so we can get #1132 into production.

@kjozwiak kjozwiak merged commit 0788078 into main Jul 23, 2024
7 checks passed
@kjozwiak kjozwiak deleted the ShivanKaul-patch-1 branch July 23, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShivanKaul @kjozwiak