Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable P3A Nebula for nightly/beta #1100

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Enable P3A Nebula for nightly/beta #1100

merged 2 commits into from
Jun 28, 2024

Conversation

DJAndries
Copy link
Collaborator

No description provided.

@DJAndries DJAndries requested a review from a team as a code owner June 24, 2024 19:32
kjozwiak
kjozwiak approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging so QA can verify via staging before pushing into production via #1099.

@kjozwiak kjozwiak merged commit 22c6ec8 into main Jun 28, 2024
6 checks passed
@kjozwiak kjozwiak deleted the nebula-nightly-beta branch June 28, 2024 17:50
@kjozwiak
Copy link
Member

kjozwiak commented Jul 3, 2024 •
edited
Loading

Quick note: The above feature was verified by @GeetaSarvadnya on Nightly via brave/brave-core#22522 (comment) before being uplifted into 1.68.x (BETA). It was also verified via 1.68.x as per brave/brave-browser#35841 (comment) & brave/brave-browser#35841 (comment). So with the following cases, we'll just ensure that users on Nightly & BETA are being added into the BraveP3ANebulaNightlyBeta study.

Win x64 verification

Nightly - BraveP3ANebulaNightlyBeta:Enabled - PASSED

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.69.73 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit)
-- | --
Revision | ebfe046ab1178f2195d83704420ed1ffa0370804
OS | Windows 11 Version 23H2 (Build 22631.3810)
  • launched/Restarted 1.69.73 Chromium: 127.0.6533.26 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveP3ANebulaNightlyBeta:Enabled via brave://version

image

Release - BraveP3ANebulaNightlyBeta not being applied - PASSED

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Windows 11 Version 23H2 (Build 22631.3810)
  • launched/Restarted 1.67.123 Chromium: 126.0.6478.126 using brave.exe --enable-logging=stderr --reset-variation-state --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveP3ANebulaNightlyBeta is not appearing/being displayed under brave://version

image

Android verification

Quick note: Ensured that Android is pointing to https://variations.bravesoftware.com/seed before launching Brave.

Nightly - BraveP3ANebulaNightlyBeta:Enabled - PASSED

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.69.76 Chromium: 127.0.6533.26 (Official Build) canary (64-bit)
--- | ---
Revision | 4107ae75ca3c5250fe11689a40d3cc3e35c22cac
OS | Android 15; Build/AP31.240517.022; 35; REL
  • launched 1.69.76 Chromium: 127.0.6533.26
  • ensured that BraveP3ANebulaNightlyBeta:Enabled via brave://version

Screenshot_20240703-130615

BETA - BraveP3ANebulaNightlyBeta:Enabled - PASSED

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.68.107 Chromium: 127.0.6533.26 (Official Build) beta (64-bit)
--- | ---
Revision | 131a9beda9f0aea74f948286e5e8c63153d9f7f8
OS | Android 15; Build/AP31.240517.022; 35; REL
  • launched 1.68.107 Chromium: 127.0.6533.26
  • ensured that BraveP3ANebulaNightlyBeta:Enabled via brave://version

Screenshot_20240703-130851

Release - BraveP3ANebulaNightlyBeta not being applied - PASSED

Verification PASSED on Pixel 6 Pro running Android 15 using the following build(s):

Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
--- | ---
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Android 15; Build/AP31.240517.022; 35; REL
  • launched 1.67.123 Chromium: 126.0.6478.126
  • ensured that BraveP3ANebulaNightlyBeta is not appearing/being displayed under brave://version

Screenshot_20240703-133111

iOS verification

Nightly - BraveP3ANebulaNightlyBeta:Enabled - PASSED

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

Brave | 1.69.76 Chromium: 127.0.6533.26 (Official Build) nightly (64-bit)
--- | ---
Revision | 4107ae75ca3c...
OS | iOS
  • installed 1.69.76 Chromium: 127.0.6533.26
  • before launching Brave, disabled the network/internet on the target device device
  • changed Variations URL under BraveCore Switches under Developer Options
    • changed to https://variations.bravesoftware.com/seed
  • launched/restarted 1.69.76 Chromium: 127.0.6533.26
  • ensured that BraveP3ANebulaNightlyBeta:Enabled via brave://version

IMG_0334

BETA - BraveP3ANebulaNightlyBeta:Enabled - PASSED

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

Brave | 1.68.106 Chromium: 126.0.6478.126 (Official Build) beta (64-bit)
--- | --- 
Revision | 8d682ca0cb83...
OS | iOS
  • installed 1.68.106 Chromium: 126.0.6478.126
  • before launching Brave, disabled the network/internet on the target device device
  • changed Variations URL under BraveCore Switches under Developer Options
    • changed to https://variations.bravesoftware.com/seed
  • launched/restarted 1.68.106 Chromium: 126.0.6478.126
  • ensured that BraveP3ANebulaNightlyBeta:Enabled via brave://version

IMG_0335

Release - BraveP3ANebulaNightlyBeta not being applied - PASSED

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

Brave | 1.67.127 Chromium: 126.0.6478.126 (Official Build) stable (64-bit) 
--- | ---
Revision | c681f72abc72...
OS | iOS
  • installed 1.67.127 Chromium: 126.0.6478.126
  • before launching Brave, disabled the network/internet on the target device device
  • changed Variations URL under BraveCore Switches under Developer Options
    • changed to https://variations.bravesoftware.com/seed
  • launched/restarted 1.67.127 Chromium: 126.0.6478.126
  • ensured that BraveP3ANebulaNightlyBeta is not appearing/being displayed under brave://version

IMG_0336

@kjozwiak kjozwiak mentioned this pull request Jul 3, 2024
Merged
@kjozwiak kjozwiak mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DJAndries @kjozwiak