Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest V2 feature => 100% on Beta, 25% on Release #1097

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

ShivanKaul
Copy link
Collaborator

No description provided.

@ShivanKaul ShivanKaul requested a review from a team as a code owner June 24, 2024 18:13
ShivanKaul added a commit that referenced this pull request Jun 24, 2024
@ShivanKaul ShivanKaul changed the title Manifest V2 feature => 100% on Beta/Release Manifest V2 feature => 100% on Beta, 25% on Release Jun 25, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main so QA can run through the above quickly before merging #1098 into production.

@kjozwiak kjozwiak merged commit af9648c into main Jun 25, 2024
6 checks passed
@kjozwiak kjozwiak deleted the ShivanKaul-patch-1 branch June 25, 2024 17:42
@kjozwiak
Copy link
Member

kjozwiak commented Jun 27, 2024

Win x64 verification(s)

Nightly - ExtensionsManifestV2Study:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.69.62 Chromium: 127.0.6533.17 (Official Build) nightly (64-bit)
-- | --
Revision | 50af8e07a47dfe29f581936e45c07e8ee8b676f5
OS | Windows 11 Version 23H2 (Build 22631.3810)

As per #1064 (comment), this was already enabled/checked on Nightly before initially pushing out ExtensionsManifestV2Study on Nightly. Quickly checked 1.69.62 Chromium: 127.0.6533.17 and ensured it was still working as expected.

Example Example
image image

BETA

Can't check BETA right now as the --variations-server-url=https://variations.bravesoftware.com/seed switch doesn't work. We'll need to get brave/brave-core#24387 uplifted into 1.68.x and get a new build. However, we'll check BETA once the above goes live to ensure everything is working.

Release - ExtensionsManifestV2StudyRelease:Default

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Windows 11 Version 23H2 (Build 22631.3810)
  • installed/launched 1.67.123 Chromium: 126.0.6478.126 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • re-launched 1.67.123 Chromium: 126.0.6478.126 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ExtensionsManifestV2StudyRelease:Default via brave://version
  • ensured that Manigest V2 extensions isn't visible/available via brave://settings/extensions
Example Example
image image

Release - ExtensionsManifestV2StudyRelease:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Windows 11 Version 23H2 (Build 22631.3810)
  • installed/launched 1.67.123 Chromium: 126.0.6478.126 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • re-launched 1.67.123 Chromium: 126.0.6478.126 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ExtensionsManifestV2StudyRelease:Enabled via brave://version
  • ensured that Manigest V2 extensions is visible/available via brave://settings/extensions
Example Example Example
image image image

Release - ExtensionsManifestV2StudyRelease (not appearing due to min_version requirement)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.65.133 Chromium: 124.0.6367.208 (Official Build) (64-bit)
-- | --
Revision | a719189e6a0245a6ce7fab3ddc637e8bd75aed08
OS | Windows 11 Version 23H2 (Build 22631.3810)
  • installed/launched 1.65.133 Chromium: 124.0.6367.208 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • re-launched 1.65.133 Chromium: 124.0.6367.208 using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ExtensionsManifestV2StudyRelease is not being displayed/appearing under brave://version
  • ensured that Manigest V2 extensions is not visible/available via brave://settings/extensions
Example Example
image image

kjozwiak pushed a commit that referenced this pull request Jun 27, 2024
* Manifest V2 feature => 100% on Beta/Release

main PR: #1097

* Manifest V2 feature: Release to 25%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants