-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest V2 feature => 100% on Beta, 25% on Release #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Merging into main
so QA can run through the above quickly before merging #1098 into production
.
|
Example |
Example |
---|---|
BETA
Can't check BETA right now as the --variations-server-url=https://variations.bravesoftware.com/seed
switch doesn't work. We'll need to get brave/brave-core#24387 uplifted into 1.68.x
and get a new build. However, we'll check BETA
once the above goes live to ensure everything is working.
Release
- ExtensionsManifestV2StudyRelease:Default
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Windows 11 Version 23H2 (Build 22631.3810)
- installed/launched
1.67.123 Chromium: 126.0.6478.126
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- re-launched
1.67.123 Chromium: 126.0.6478.126
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
ExtensionsManifestV2StudyRelease:Default
viabrave://version
- ensured that
Manigest V2 extensions
isn't visible/available viabrave://settings/extensions
Example |
Example |
---|---|
Release
- ExtensionsManifestV2StudyRelease:Enabled
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.67.123 Chromium: 126.0.6478.126 (Official Build) (64-bit)
-- | --
Revision | fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS | Windows 11 Version 23H2 (Build 22631.3810)
- installed/launched
1.67.123 Chromium: 126.0.6478.126
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- re-launched
1.67.123 Chromium: 126.0.6478.126
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
ExtensionsManifestV2StudyRelease:Enabled
viabrave://version
- ensured that
Manigest V2 extensions
is visible/available viabrave://settings/extensions
Example |
Example |
Example |
---|---|---|
Release
- ExtensionsManifestV2StudyRelease
(not appearing due to min_version
requirement)
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.65.133 Chromium: 124.0.6367.208 (Official Build) (64-bit)
-- | --
Revision | a719189e6a0245a6ce7fab3ddc637e8bd75aed08
OS | Windows 11 Version 23H2 (Build 22631.3810)
- installed/launched
1.65.133 Chromium: 124.0.6367.208
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- re-launched
1.65.133 Chromium: 124.0.6367.208
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
ExtensionsManifestV2StudyRelease
is not being displayed/appearing underbrave://version
- ensured that
Manigest V2 extensions
is not visible/available viabrave://settings/extensions
Example |
Example |
---|---|
* Manifest V2 feature => 100% on Beta/Release main PR: #1097 * Manifest V2 feature: Release to 25%
No description provided.