Debounce ad clicked events for 1 second - Production #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
changed the title
tmancey
changed the title
tmancey
force-pushed
the
debounce_ad_clicked_event_prod
branch
2 times, most recently
from
0f806d9 to
39ab250
Compare
aseren
force-pushed
the
debounce_ad_clicked_event_prod
branch
from
39ab250 to
77febba
Compare
kjozwiak
approved these changes
May 31, 2024
There was a problem hiding this comment.
Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on staging as per #1059 (comment), #1059 (comment) & #1059 (comment). Quick note that the above study is currently not applicable to 1.66.x as per https://bravesoftware.slack.com/archives/C01LKMP6X36/p1717008052163979?thread_ts=1715794248.488579&cid=C01LKMP6X36. However as per https://bravesoftware.slack.com/archives/C01LKMP6X36/p1717018510213729?thread_ts=1715794248.488579&cid=C01LKMP6X36, it shouldn't cause any issues on 1.66.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #1059