-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add seed tools. #1026
Add seed tools. #1026
Conversation
235dde7
to
482d95e
Compare
b9f85c5
to
5482696
Compare
e314b08
to
daa11e3
Compare
const intValue = Number.isInteger(value) ? value : parseInt(value); | ||
return new Date(intValue * 1000).toISOString(); | ||
} | ||
case 'channel': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we pass a param isBrave: boolean = true to make the tools work for Finch seed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added Options.isChromium
to disable the channel modification if set to true.
src/scripts/generate_proto_ts.ts
Outdated
// You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
||
import { program } from '@commander-js/extra-typings'; | ||
import * as execa from 'execa'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, does execa
have advantages over child_process
for our usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, execa
is capable of launching scripts from node_modules
(with preferLocal: true
) the same way as npx <...>
works. This way we don't need to create a custom path like node_modules/bin/...
manually.
69152bb
to
de85ea3
Compare
@atuchin-m @iefremov ptal |
[puLL-Merge] - brave/brave-variations@1026 DescriptionThis PR introduces significant changes to the Brave Variations project, including new tools for managing and validating study files, improved seed generation, and various utility functions. The changes aim to enhance the robustness and functionality of the variations system, particularly in handling study files and generating seed data. Possible Issues
Security Hotspots
ChangesChanges
These changes significantly enhance the project's capabilities in managing and validating study files, generating seeds, and overall improving the robustness of the variations system. |
This PR adds
seed_tools
CLI tool to support seed manipulation stored in per-file format.Related: brave/brave-browser#33654