Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BraveRoundTimeStamps to fix Spotify crashes #1214

Closed
atuchin-m opened this issue Sep 24, 2024 · 0 comments · Fixed by #1215 or #1224
Closed

Disable BraveRoundTimeStamps to fix Spotify crashes #1214

atuchin-m opened this issue Sep 24, 2024 · 0 comments · Fixed by #1215 or #1224
Assignees

Comments

@atuchin-m
Copy link
Collaborator

We should disable the feature until we find another solution.
The details:
brave/brave-browser#40886 (comment)

@atuchin-m atuchin-m self-assigned this Sep 24, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
Resolves #1214

Nightly & Beta: 100%
Release: 5%

Disabling the feature just returns the code to the upstream state, so
it's relatively safe.
Just to be sure let's start with 5% now and go to 100% the new day.
@atuchin-m atuchin-m reopened this Oct 10, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2024
For #1214

According to backtrace.io data disabling the feature helps:
Default (95%), `ebc44611-ca7d8d80`, still crashes on Spotify: 
https://share.backtrace.io/api/share/5yTIx1x1ZTzUOoi6K0VApLn3

Disabled (5%), `ebc44611-3d47f4f4`, only few crashes a day, no
RequestIdeCallback crashes:
https://share.backtrace.io/api/share/HWOa9G64FZWfx3SLx1Ks8hg2
github-merge-queue bot pushed a commit that referenced this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant