Skip to content

Commit

Permalink
Adds Serg to alert about GPU related features changes via finch (#1196)
Browse files Browse the repository at this point in the history
Resolves #1195
  • Loading branch information
SergeyZhukovsky authored Aug 22, 2024
1 parent 9a56ae8 commit a81355e
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,16 @@ module.exports = {
'MetricsClearLogsOnClonedInstall',
],

gpuRelatedFeatures: [
'DefaultANGLEVulkan',
'DefaultPassthroughCommandDecoder',
'EnableDrDcVulkan',
'Vulkan',
'VulkanFromANGLE',
'VulkanV2',
'VulkanVMALargeHeapBlockSizeExperiment',
],

// Add your slack ID to get notifications about new kill switches.
// To retrive it use Slack profile => Copy Member ID.
killSwitchNotificationIds: [
Expand All @@ -32,4 +42,7 @@ module.exports = {
'U02DG0ATML3', // @matuchin
'UE87NRK2A', // @iefremov
],
gpuRelatedNotificationIds: [
'U0D73ULKD', // @serg
],
};
16 changes: 16 additions & 0 deletions src/core/summary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ export function summaryToJson(
const output = new MrkdwnMessage();
let hasKillSwitchImportantUpdate = false;
let hasBadStudies = false;
let gpuRelatedFeaturesDetected = false;

// From the highest to the lowest priority:
const priorityList = Object.values(StudyPriority)
Expand All @@ -292,6 +293,12 @@ export function summaryToJson(
);
itemList.sort((a, b) => a.action - b.action);
for (const e of itemList) {
for (const f of e.affectedFeatures) {
if (config.gpuRelatedFeatures.includes(f)) {
gpuRelatedFeaturesDetected = true;
break;
}
}
hasKillSwitchImportantUpdate ||= e.isKillSwitchImportantUpdate();
hasBadStudies ||= e.hasBadStudies;
const block = new TextBlock(e.actionToText());
Expand Down Expand Up @@ -328,6 +335,15 @@ export function summaryToJson(
}
if (output.toString() === '') return undefined;

if (gpuRelatedFeaturesDetected) {
output.addBlockToTop(
new TextBlock(
'GPU related changes detected, cc ' +
config.gpuRelatedNotificationIds.map((i) => `<@${i}>`).join(),
),
);
}

if (hasKillSwitchImportantUpdate) {
output.addBlockToTop(
new TextBlock(
Expand Down

0 comments on commit a81355e

Please sign in to comment.