Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proprietary_codecs:true to perf chromium build #27096

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Dec 27, 2024

Resolves brave/brave-browser#43056

The flag is enabled for Chrome and Brave, but not for Chromium reference builds. We need to explicitly enable it to make the reference build that same as Chrome in terms of perf.

The flag is enabled for Chrome and Brave, but not for Chromium reference builds. We need to explicitly enable gn flag proprietary_codecs for that.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m requested a review from a team as a code owner December 27, 2024 11:51
@atuchin-m atuchin-m requested a review from iefremov December 27, 2024 15:06
@atuchin-m atuchin-m merged commit 5edaaef into master Dec 27, 2024
21 checks passed
@atuchin-m atuchin-m deleted the use-proprietary_codecs-to-build-chromium branch December 27, 2024 16:41
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 27, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.132

@ghost
Copy link

ghost commented Jan 1, 2025

Where can I find the Chromium reference Builds or are they only for employees?

@atuchin-m
Copy link
Collaborator Author

It isn't a public thing, at least yet. You can make them using npm run build_chromium_release

Also, there is Chrome for Testing:
https://googlechromelabs.github.io/chrome-for-testing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Perf] 43.4% regression in GPU system_health.memory_desktop after cr132
3 participants