fix(wallet): Transactions Partner Modal Bugs

[Douglashdaniel]

Description

• Fixes a bug where the Transactions Partner consent modal would keep popping up when navigating to other tabs.
• Fixes a bug where the Transactions Partner consent modal would not pop up when navigating from Swap, Send, Bridge or Deposit
• Fixes a bug where the Transactions Partner consent modal would not pop up if you manually navigated to brave://wallet/crypto/fund-wallet

Resolves brave/brave-browser#42984
Resolves brave/brave-browser#42785

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Test Modal Keeps Appearing Bug

1. Create a band new Wallet.
2. Navigate to the Buy screen, once the Transactions Partner consent modal pops up click the x button to close.
3. Now navigate to any other tab for example Activity.
4. The modal should not reappear unless you navigate back to the Buy tab.

Before:

Screen.Recording.36.mov

After:

Screen.Recording.35.mov

Test Modal Not Appearing when Manually navigating Bug

1. Create a band new Wallet.
2. Manually enter brave://wallet/crypto/fund-wallet in the address bar.
3. The Transactions Partner consent modal should appear.

Before:

Screen.Recording.37.mov

After:

Screen.Recording.33.mov

Test Modal Not Appearing when navigating from Send/Swap/Bridge/Deposit Bug

1. Create a band new Wallet.
2. Navigate to Send, Swap, Bridge or Deposit.
3. Now navigate to the Buy tab.
4. The Transactions Partner consent modal should appear.

Before:

Screen.Recording.38.mov

After:

Screen.Recording.34.mov

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

Released in v1.75.114

[srirambv]

Verification passed on

Brave	1.75.114 Chromium: 132.0.6834.46 (Official Build) nightly (64-bit)
Revision	2c7caf1
OS	Windows 11 Version 23H2 (Build 22631.4460)

• Verified steps from PR description
• Verified when selecting Buy transaction partner modal is shown
• Verified navigating to other tabs doesn't show the transaction partner modal
• Verified manually navigating to brave://wallet/fund-wallet shows the transaction partner modal
• Verified manually navigating to other routes doesn't show the transaction partner modal

27071.mp4