-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent external favicons fetch on password manager page. #27066
Conversation
with open(definition_file, encoding='utf-8', mode='r') as f: | ||
content = f.read() | ||
|
||
if POLYMER_OVERRIDING_TOKEN in content: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if chromium_src override doesn't have //resources/polymer/v3_0/polymer/polymer_bundled.min.js
line, then template html is treated incorrectly.
our overrides can miss this line when it's not necessary, so we need to improve the content detector to handle such cases.
A Storybook has been deployed to preview UI for the latest push |
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look. |
b650d1b
to
afaf7fa
Compare
Released in v1.75.116 |
Disable
cr-auto-img
fetch introduced in CL [1]. Insteadchrome://favicon2
-based div is used which only access cached icons.Resolves brave/brave-browser#42955
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: