Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Fix user sometimes cannot scroll the tab bar #27061

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Dec 18, 2024

Resolves brave/brave-browser#41562

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. make sure issue Fix #7851: Tab selection for TabsBar interface is done after active website is loaded brave-ios#8032 is not regressed after this PR
  2. verify issue Some users cannot scroll on the tabs bar on iOS brave-browser#41562 is no longer happening
    Note: issue Some users cannot scroll on the tabs bar on iOS brave-browser#41562 is very hard to reproduce. Make sure you have enough tabs open and try some crazy scenarios.

… resolve the issue that users cannot scroll tabbar
@nuo-xu nuo-xu added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Dec 18, 2024
@nuo-xu nuo-xu requested a review from Brandon-T December 18, 2024 17:35
@nuo-xu nuo-xu self-assigned this Dec 18, 2024
@nuo-xu nuo-xu requested a review from a team as a code owner December 18, 2024 17:35
@nuo-xu nuo-xu merged commit 9a628b7 into master Dec 19, 2024
19 checks passed
@nuo-xu nuo-xu deleted the bugfix/41562 branch December 19, 2024 19:20
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 19, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some users cannot scroll on the tabs bar on iOS
3 participants