Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeowner - new WebUI should use RegisterChromeWebUIConfigs #27057

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Dec 18, 2024

Resolves brave/brave-browser#42952

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bridiver bridiver requested review from bsclifton and a team as code owners December 18, 2024 16:56
@bridiver bridiver added the CI/skip Do not run CI builds (except noplatform) label Dec 18, 2024
@bridiver bridiver enabled auto-merge (squash) December 18, 2024 16:58
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bridiver bridiver merged commit ec740d8 into master Dec 18, 2024
21 checks passed
@bridiver bridiver deleted the webui-config branch December 18, 2024 18:44
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 18, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New WebUI should use RegisterChromeWebUIConfigs
4 participants