Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop settings fixes (#26551) #27050

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Desktop settings fixes (#26551) #27050

merged 1 commit into from
Dec 20, 2024
+3 −2

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Dec 17, 2024 •
edited by LaurenWags
Loading

Uplift of #26551
Resolves brave/brave-browser#42058

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@aguscruiz @emerick
Desktop settings fixes (#26551)
af400e0 
* Update settings_manage_profile.ts

* Add Manage Profile page to customize padding

* imports: order alphabetically

* Fix brave://settings/braveSync/setup image padding

Fixes the image being left out of the margin

* Fix padding on inner setting pages

* changed token to spacing

* Update settings_manage_profile.ts

* Fix section titles size

Made titles a bit smaller so we don't have overlapping issues on line breaks

* revert changes to safety check

* revert change to settings-header file

* Update br_settings_shared.css
@emerick emerick added this to the 1.74.x - Beta milestone Dec 17, 2024
@emerick emerick self-assigned this Dec 17, 2024
@emerick emerick requested a review from a team as a code owner December 17, 2024 20:00
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 17, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

LaurenWags
LaurenWags approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.74.x is approved 👍🏻 QA has verified the PR using 1.75.x/Nightly as per #26551 (comment).

@LaurenWags LaurenWags merged commit 99d0cee into 1.74.x Dec 20, 2024
17 checks passed
@LaurenWags LaurenWags deleted the pr26551_desktop-settings-fixes_1.74.x branch December 20, 2024 14:50
@brave-builds
Copy link
Collaborator

Released in v1.74.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@emerick emerick

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@emerick @brave-builds @LaurenWags @aguscruiz