Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use precomputed caller in the file save dialog title. (uplift to 1.74.x) #27040

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Use precomputed caller in the file save dialog title. (uplift to 1.74.x) #27040

merged 1 commit into from
Dec 17, 2024
+18 −15

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 17, 2024 •
edited by LaurenWags
Loading

Uplift of #26953
Resolves brave/brave-browser#42772

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner December 17, 2024 06:57
@brave-builds brave-builds requested a review from a team December 17, 2024 06:57
@brave-builds brave-builds added this to the 1.74.x - Beta milestone Dec 17, 2024
@brave-builds brave-builds self-assigned this Dec 17, 2024
LaurenWags
LaurenWags approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.74.x is approved 👍🏻 QA has verified the PR using 1.75.x/Nightly as per https://github.com/brave/internal/issues/1238#issuecomment-2548577537.

@LaurenWags LaurenWags merged commit e6ff847 into 1.74.x Dec 17, 2024
17 checks passed
@LaurenWags LaurenWags deleted the pr26953_issues/42772_1.74.x branch December 17, 2024 15:24
@brave-builds
Copy link
Collaborator Author

Released in v1.74.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.74.x - Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @LaurenWags