Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YouTube creator detection for search navigations #27033

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#42791

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing requested a review from a team as a code owner December 16, 2024 18:11
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 16, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing
Copy link
Collaborator Author

SonarCloud is preferring elem?.checkVisibility() to elem && elem.checkVisibility() based on readability. In this case, I think that the longer form better matches the intent.

@zenparsing zenparsing merged commit 4f0ba29 into master Dec 16, 2024
18 of 19 checks passed
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 16, 2024
@zenparsing zenparsing deleted the ksmith-yt-detection-fix branch December 16, 2024 20:06
@brave-builds
Copy link
Collaborator

Released in v1.75.104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect creator information on panel in certain cases on YT - follow up to 34237
3 participants