Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable CustomBackgroundFileManagerBrowserTest.SaveImageMultipleTimes on Mac" (uplift to 1.73.x) #27030

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Revert "Disable CustomBackgroundFileManagerBrowserTest.SaveImageMultipleTimes on Mac" (uplift to 1.73.x) #27030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions browser/ntp_background/custom_background_file_manager_browsertest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#include "base/threading/thread_restrictions.h"
#include "brave/browser/ntp_background/constants.h"
#include "brave/components/constants/brave_paths.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
Expand Down Expand Up @@ -112,16 +111,8 @@ IN_PROC_BROWSER_TEST_F(CustomBackgroundFileManagerBrowserTest,
EXPECT_TRUE(base::PathExists(test_file()));
}

#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM_FAMILY)
// On Mac ARM CI node, this test is flaky because of timeout.
// https://github.com/brave/brave-browser/issues/29762
#define MAYBE_SaveImageMultipleTimes DISABLED_SaveImageMultipleTimes
#else
#define MAYBE_SaveImageMultipleTimes SaveImageMultipleTimes
#endif

IN_PROC_BROWSER_TEST_F(CustomBackgroundFileManagerBrowserTest,
MAYBE_SaveImageMultipleTimes) {
SaveImageMultipleTimes) {
for (int i = 0; i < 3; i++) {
base::RunLoop run_loop;
base::FilePath expected_path =
Expand Down
Loading