Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for crbug.com/6013664 #27028

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Dec 16, 2024

Resolves brave/brave-browser#42920

Chromium uplifted the fix to CR132: https://chromium-review.googlesource.com/c/chromium/src/+/6081238

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m self-assigned this Dec 16, 2024
@atuchin-m atuchin-m requested a review from a team as a code owner December 16, 2024 15:08
@atuchin-m atuchin-m enabled auto-merge (squash) December 16, 2024 15:25
@atuchin-m atuchin-m merged commit 09cf2a7 into master Dec 16, 2024
21 checks passed
@atuchin-m atuchin-m deleted the remove-workaround-for-crbug-378381144 branch December 16, 2024 16:56
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 16, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert workaround for https://crbug.com/378381144
3 participants