Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Wallet) Fix crash KeystoreHelper class #27027

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

simoarpe
Copy link
Collaborator

Resolves brave/brave-browser#42860

Fixes an issue where keyStore.getEntry(BRAVE_WALLET_ALIAS, null) may return null so getCipherForDecryption method must introduce a check and return null.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

@simoarpe simoarpe added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Dec 16, 2024
@simoarpe simoarpe self-assigned this Dec 16, 2024
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simoarpe simoarpe merged commit 73be2eb into master Dec 16, 2024
19 checks passed
@simoarpe simoarpe deleted the simone/fix-keystore-helper branch December 16, 2024 17:04
@simoarpe simoarpe restored the simone/fix-keystore-helper branch December 16, 2024 17:05
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 16, 2024
brave-builds added a commit that referenced this pull request Dec 16, 2024
brave-builds added a commit that referenced this pull request Dec 16, 2024
kjozwiak pushed a commit that referenced this pull request Dec 16, 2024
kjozwiak pushed a commit that referenced this pull request Dec 16, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in KeystoreHelper
3 participants