Leo AI becomes an installable PWA #27025

petemill · 2024-12-16T06:35:42Z

Issues:

Resolves Leo AI Full-Page (chrome://leo-ai) should prompt for PWA install brave-browser#42701
Resolves Leo AI favicon should be full-color in light theme brave-browser#42915
Resolves AI Chat should show conversation title in tab title brave-browser#42916

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

brave-builds · 2024-12-16T07:48:09Z

A Storybook has been deployed to preview UI for the latest push

simonhong · 2024-12-16T10:03:24Z

chromium_src/chrome/browser/banners/app_banner_manager_desktop_browsertest.cc

@@ -0,0 +1,42 @@
+// Copyright (c) 2024 The Brave Authors. All rights reserved.


IMO, it would be better to have this browser test in our test target because we don't run upstream browser test on all platforms.

moved to brave/browser/banners/

oops, I forgot to actually delete this file

simonhong · 2024-12-16T10:05:32Z

chromium_src/chrome/browser/banners/app_banner_manager_desktop_browsertest.cc

+    scoped_feature_list_.InitWithFeatures(
+        /*enabled_features=*/{}, GetDisabledFeatures());


nit: I think it's not necessary.

simonhong · 2024-12-16T10:09:34Z

chromium_src/chrome/browser/banners/app_banner_manager_desktop_browsertest.cc

+  {
+    base::RunLoop run_loop;
+    manager->PrepareDone(run_loop.QuitClosure());
+
+    ASSERT_TRUE(ui_test_utils::NavigateToURL(
+        browser(), GURL(base::StrCat({"chrome://", kAIChatUIHost}))));
+    run_loop.Run();
+  }


I think this could be simplifed.

ASSERT_TRUE(ui_test_utils::NavigateToURL( browser(), GURL(base::StrCat({"chrome://", kAIChatUIHost})))); manager->WaitForInstallableCheck();

I'm not sure why the chromium browser test to check the same thing for chrome://password-manager doesn't do that

But great spot - this works!

bsclifton

string reviewers ++

simonhong

++

simonhong · 2024-12-17T00:44:00Z

browser/banners/BUILD.gn

+# License, v. 2.0. If a copy of the MPL was not distributed with this file,
+# You can obtain one at https://mozilla.org/MPL/2.0/.
+
+if (!is_android) {


Maybe we don't need this check as this browser_tests target is already filtered in test/BUILD.gn ?

petemill · 2024-12-17T06:46:48Z

Windows CI failed with unrelated flakey test:

AdblockCustomResourcesTest.AddEditRemoveScriptlet

goodov

lgtm with few things to improve

goodov · 2024-12-17T07:08:34Z

chromium_src/components/webapps/browser/banners/DEPS

@@ -0,0 +1,3 @@
+include_rules = [
+  "+brave/components/constants",


this dependency should also appear in components/webapps/browser/BUILD.gn

goodov · 2024-12-17T07:11:34Z

chromium_src/chrome/browser/web_applications/web_app_helpers.cc

+bool IsValidWebAppUrl(const GURL& app_url) {
+  return IsValidWebAppUrl_ChromiumImpl(app_url) ||
+         (app_url.SchemeIs(content::kChromeUIScheme) &&
+          base::Contains(kInstallablePWAWebUIHosts, app_url.host()));


host_piece()

goodov · 2024-12-17T07:14:26Z

chromium_src/components/webapps/browser/banners/app_banner_manager.cc

+// Add some extra items to WebUI hosts considered valid for PWAs
+#define kChromeUIPasswordManagerHost \
+  kChromeUIPasswordManagerHost &&    \
+      !base::Contains(kInstallablePWAWebUIHosts, url.host())


host_piece()

brave-builds · 2024-12-17T12:04:33Z

Released in v1.75.105

petemill requested review from simonhong and mkarolin December 16, 2024 06:35

petemill self-assigned this Dec 16, 2024

petemill requested review from a team as code owners December 16, 2024 06:35

github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 16, 2024

petemill force-pushed the leo-pwa-manifest branch from ceb70ba to 6e90cd6 Compare December 16, 2024 07:10

simonhong reviewed Dec 16, 2024

View reviewed changes

bsclifton approved these changes Dec 16, 2024

View reviewed changes

petemill force-pushed the leo-pwa-manifest branch from 6e90cd6 to 879ea14 Compare December 17, 2024 00:29

petemill requested a review from a team as a code owner December 17, 2024 00:29

simonhong approved these changes Dec 17, 2024

View reviewed changes

petemill force-pushed the leo-pwa-manifest branch from 879ea14 to 941c22a Compare December 17, 2024 04:41

petemill enabled auto-merge December 17, 2024 06:49

goodov approved these changes Dec 17, 2024

View reviewed changes

petemill added 3 commits December 16, 2024 23:54

[AI Chat] WebManifest for PWA install

6a1d9fe

Use color favicon for AI Chat

6357259

AI Chat gets conversation title as Tab title and better PWA name

7b673e7

petemill force-pushed the leo-pwa-manifest branch from 941c22a to 7b673e7 Compare December 17, 2024 07:54

petemill requested review from a team as code owners December 17, 2024 07:54

petemill merged commit 10f7318 into master Dec 17, 2024
18 checks passed

petemill deleted the leo-pwa-manifest branch December 17, 2024 09:23

github-actions bot added this to the 1.75.x - Nightly milestone Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leo AI becomes an installable PWA #27025

Leo AI becomes an installable PWA #27025

petemill commented Dec 16, 2024 •

edited

Loading

brave-builds commented Dec 16, 2024

simonhong Dec 16, 2024

petemill Dec 17, 2024

petemill Dec 17, 2024

simonhong Dec 16, 2024

petemill Dec 17, 2024

simonhong Dec 16, 2024

petemill Dec 17, 2024

petemill Dec 17, 2024

petemill Dec 17, 2024

bsclifton left a comment

simonhong left a comment

simonhong Dec 17, 2024

petemill commented Dec 17, 2024

goodov left a comment

goodov Dec 17, 2024

goodov Dec 17, 2024

goodov Dec 17, 2024

brave-builds commented Dec 17, 2024

		@@ -0,0 +1,42 @@
		// Copyright (c) 2024 The Brave Authors. All rights reserved.

		scoped_feature_list_.InitWithFeatures(
		/enabled_features=/{}, GetDisabledFeatures());

		@@ -0,0 +1,3 @@
		include_rules = [
		"+brave/components/constants",

Leo AI becomes an installable PWA #27025

Leo AI becomes an installable PWA #27025

Conversation

petemill commented Dec 16, 2024 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented Dec 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsclifton left a comment

Choose a reason for hiding this comment

simonhong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petemill commented Dec 17, 2024

goodov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brave-builds commented Dec 17, 2024

petemill commented Dec 16, 2024 •

edited

Loading