Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced lint-suppressions.xml.patch with python chromium_src override #27020

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Dec 13, 2024

Resolves brave/brave-browser#42901

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Not supposed for QA, but for devs mostly

  1. Run regular build - should succeed
  2. Run the same build - should succeed and should be fast and report nothing changed
  3. Edit chromium_src/chrome/android/expectations/lint-suppressions.xml with some white spaces
  4. Run build - it should succeed but but should take some time
  5. Comment out issues at chromium_src/chrome/android/expectations/lint-suppressions.xml, run build - it should fail.

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner December 16, 2024 11:47
@AlexeyBarabash AlexeyBarabash merged commit 04da656 into master Dec 16, 2024
18 checks passed
@AlexeyBarabash AlexeyBarabash deleted the android_lint_suppressions branch December 16, 2024 13:43
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 16, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace lint-suppressions.xml.patch with python chromium_src override
4 participants