Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nala dependency #27012

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Update nala dependency #27012

merged 1 commit into from
Dec 13, 2024

Conversation

petemill
Copy link
Member

@petemill petemill commented Dec 13, 2024

Very minor update from nala to fix ButtonMenus

brave/leo@06bbaa8...19ec23c

Issues:

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

- [ButtonMenu] onclick does need stopPropagation after all to stop the Menu being blurred and closing itself
@petemill petemill self-assigned this Dec 13, 2024
@petemill petemill requested a review from a team as a code owner December 13, 2024 08:37
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Dec 13, 2024
@petemill petemill enabled auto-merge December 13, 2024 08:37
@petemill petemill merged commit 5d7fb2b into master Dec 13, 2024
19 checks passed
@petemill petemill deleted the nala-button-fix-2 branch December 13, 2024 16:10
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 13, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nala update
3 participants