Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove animations open yt dialog #27000

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Dec 12, 2024

Resolves brave/brave-browser#42864

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please follow the test plan from : #26595 (comment)
With this PR, we replaced animation with a static image.

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Dec 12, 2024
@deeppandya deeppandya added this to the 1.75.x - Nightly milestone Dec 12, 2024
@deeppandya deeppandya self-assigned this Dec 12, 2024
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya force-pushed the remove_animations_open_yt_dialog branch from 7d67db6 to d1ec780 Compare December 17, 2024 21:51
@deeppandya deeppandya enabled auto-merge December 17, 2024 23:33
@deeppandya deeppandya force-pushed the remove_animations_open_yt_dialog branch from d1ec780 to f09c28a Compare December 18, 2024 16:36
@deeppandya deeppandya merged commit 051b932 into master Dec 18, 2024
18 checks passed
@deeppandya deeppandya deleted the remove_animations_open_yt_dialog branch December 18, 2024 18:05
@brave-builds
Copy link
Collaborator

Released in v1.75.110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove animation for Open YT dialog
3 participants