Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toast notification for adding article to reading list #26998

Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Dec 12, 2024

Resolves brave/brave-browser#42857

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Dec 12, 2024
@emerick emerick requested a review from a team as a code owner December 12, 2024 17:52
@emerick emerick force-pushed the emerick-remove-added-to-reading-list-toast-notification branch from 5839442 to c9ef56f Compare December 12, 2024 18:57
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@emerick emerick force-pushed the emerick-remove-added-to-reading-list-toast-notification branch from c9ef56f to b1f0cda Compare December 12, 2024 20:00
@emerick emerick merged commit 37b9bc0 into master Dec 12, 2024
18 checks passed
@emerick emerick deleted the emerick-remove-added-to-reading-list-toast-notification branch December 12, 2024 21:48
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 12, 2024
brave-builds added a commit that referenced this pull request Dec 12, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.98

@LaurenWags
Copy link
Member

LaurenWags commented Dec 13, 2024

Verified with

Brave | 1.75.98 Chromium: 132.0.6834.46 (Official Build) nightly (arm64)
-- | --
Revision | b5b912857bea83d28937b6b8b853d74f22accb6a
OS | macOS Version 15.2 (Build 24C101)

Verified STR from brave/brave-browser#42857 (comment).
Confirmed no toast notification when adding a page to reading list via tab context menu. Confirmed pages were still added to the reading list without the toast notification.

Screen.Recording.2024-12-13.at.8.45.18.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Reading List toast notification
4 participants