Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AI Chat history feature #26996

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Enable AI Chat history feature #26996

merged 2 commits into from
Dec 13, 2024

Conversation

petemill
Copy link
Member

@petemill petemill commented Dec 12, 2024

Adds requests from security and privacy review in order to accept the feature being enabled by default:

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this Dec 12, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 12, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@petemill petemill force-pushed the enable-ai-chat-history branch from a843589 to c1805c7 Compare December 12, 2024 07:32
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@diracdeltas
Copy link
Member

This should probably be done before this is merged? https://github.com/brave/reviews/issues/1703#issuecomment-2539690183 (please check with Pat if unclear)

@petemill petemill force-pushed the enable-ai-chat-history branch from c1805c7 to a4b3732 Compare December 12, 2024 21:07
@petemill
Copy link
Member Author

The link in the notice now goes directly to the newly published sub-page about Storage https://support.brave.com/hc/en-us/articles/32663367857549-How-do-I-use-Chat-History-in-Brave-Leo

@diracdeltas
Copy link
Member

diracdeltas commented Dec 12, 2024

maybe not specific to this PR, but this seems buggy:

  1. enable AI history feature in nightly (1.75.95 for me)
  2. open leo, disable page context
  3. it shows me some suggestions but the icon next to them is blank? UPDATE: seems this is an apple problem
Screenshot 2024-12-12 at 13 55 45
  1. click on one of them, like 'formulate a business proposal'. notice the output.
  2. close leo and reopen
  3. click 'conversation history' > 'formulate a business proposal'
  4. notice the conversation is blank

@petemill
Copy link
Member Author

maybe not specific to this PR, but this seems buggy:

  1. enable AI history feature in nightly (1.75.95 for me)
  2. open leo, disable page context
  3. it shows me some suggestions but the icon next to them is blank? UPDATE: seems this is an apple problem
Screenshot 2024-12-12 at 13 55 45 4. click on one of them, like 'formulate a business proposal'. notice the output. 5. close leo and reopen 6. click 'conversation history' > 'formulate a business proposal' 7. notice the conversation is blank

@diracdeltas mentioned that emojis aren't working on any website for her, so I think we can ignore that part.

As for the second issue - the cause is:

@petemill petemill force-pushed the enable-ai-chat-history branch from a4b3732 to dec8c49 Compare December 12, 2024 23:13
@diracdeltas
Copy link
Member

no security comments from me, will let the privacy reviewer(s) approve.

@ShivanKaul
Copy link
Collaborator

I'm okay merging into Nightly as long as the privacy policy update is applied. Also, not blocking for Nightly, but these issues must be fixed before the feature is enabled beyond.

@petemill
Copy link
Member Author

petemill commented Dec 13, 2024

@petemill petemill merged commit 6f8689f into master Dec 13, 2024
18 checks passed
@petemill petemill deleted the enable-ai-chat-history branch December 13, 2024 20:15
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 13, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
5 participants