-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AI Chat history feature #26996
Conversation
A Storybook has been deployed to preview UI for the latest push |
a843589
to
c1805c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This should probably be done before this is merged? https://github.com/brave/reviews/issues/1703#issuecomment-2539690183 (please check with Pat if unclear) |
c1805c7
to
a4b3732
Compare
The link in the notice now goes directly to the newly published sub-page about Storage https://support.brave.com/hc/en-us/articles/32663367857549-How-do-I-use-Chat-History-in-Brave-Leo |
components/ai_chat/resources/page/components/notices/notice_conversation_storage.tsx
Show resolved
Hide resolved
@diracdeltas mentioned that emojis aren't working on any website for her, so I think we can ignore that part. As for the second issue - the cause is: |
a4b3732
to
dec8c49
Compare
no security comments from me, will let the privacy reviewer(s) approve. |
I'm okay merging into Nightly as long as the privacy policy update is applied. Also, not blocking for Nightly, but these issues must be fixed before the feature is enabled beyond. |
waiting for |
Released in v1.75.101 |
Adds requests from security and privacy review in order to accept the feature being enabled by default:
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: