-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Prepare CWVWebView web embedder for use in iOS #26957
base: master
Are you sure you want to change the base?
Conversation
ef209d6
to
66c250f
Compare
66c250f
to
18f7570
Compare
[puLL-Merge] - brave/brave-core@26957 DescriptionThis PR introduces significant changes to the iOS WebView implementation for the Brave browser. It adds new functionality, overrides some Chromium behaviors, and integrates Brave-specific features into the WebView component. Possible Issues
Security Hotspots
ChangesChanges
sequenceDiagram
participant App as Brave iOS App
participant Core as BraveCoreMain
participant WebView as CWVWebView
participant Client as BraveWebClient
participant Handler as CRWWKNavigationHandler
App->>Core: Initialize
Core->>WebView: Create with configuration
WebView->>Client: Set up web client
WebView->>Handler: Set up navigation handler
Handler->>Client: Handle navigation actions
Client->>Handler: Apply Brave-specific behaviors
Handler->>WebView: Update navigation state
WebView->>App: Present web content
|
This is the split-up contents of #24657. This PR in particular only adds the
CWVWebView
API and exposes it to the iOS app but does not actually contain the code that usesCWVWebView
in the iOS app. There is a shell target added (WebShell
) for simple tests, for more comprehensive tests involving multiple tabs, please use theios-cwvwebview-impl
branchResolves brave/brave-browser#42838
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: