-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): Post Confirmation Transfer Value #26939
Merged
Douglashdaniel
merged 1 commit into
master
from
fix-wallet-post-confirmation-transfer-value
Dec 12, 2024
Merged
fix(wallet): Post Confirmation Transfer Value #26939
Douglashdaniel
merged 1 commit into
master
from
fix-wallet-post-confirmation-transfer-value
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/storybook-url
Deploy storybook and provide a unique URL for each build
feature/web3/wallet
labels
Dec 9, 2024
A Storybook has been deployed to preview UI for the latest push |
onyb
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Douglashdaniel
deleted the
fix-wallet-post-confirmation-transfer-value
branch
December 12, 2024 16:02
Released in v1.75.96 |
brave-builds
added a commit
that referenced
this pull request
Dec 17, 2024
brave-builds
added a commit
that referenced
this pull request
Dec 17, 2024
This was referenced Dec 17, 2024
Verification passed on
26939.mp4 |
kjozwiak
pushed a commit
that referenced
this pull request
Dec 18, 2024
) Uplift of #26939 (squashed) to beta
kjozwiak
pushed a commit
that referenced
this pull request
Dec 18, 2024
) Uplift of #26939 (squashed) to release
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where the
Post Confirmation
panels were sometimes showing an incorrecttransfer
valueResolves brave/brave-browser#42770
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Wallet
and navigate to theSend
screenSPL-BAT
to another accountTransaction
and wait for theTransaction Status
panel to pop up.transfer
value.Before:
Screen.Recording.18.mov
After:
Screen.Recording.19.mov