Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Remove ShouldLaunchBraveAdsAsInProcessService feature #26936

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Dec 9, 2024

This change is necessary because we are executing database queries directly through the Ads library, which is incompatible with sandboxed utility processes. See #26866

The feature was enabled by default in the source code starting from 1.65.80. By the current change, we are removing the ability to disable it, so now we are always running Brave Ads as In-process service.

Resolves brave/brave-browser#42767

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Manual testing is not required.

@aseren aseren requested review from a team as code owners December 9, 2024 19:03
@github-actions github-actions bot added the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Dec 9, 2024
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@aseren aseren merged commit a08c449 into master Dec 10, 2024
21 checks passed
@aseren aseren deleted the issues/42767 branch December 10, 2024 14:40
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 10, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Remove ShouldLaunchBraveAdsAsInProcessService feature
4 participants