Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toolbar]: Fix close search button #26874

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#42678

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

@fallaciousreasoning fallaciousreasoning requested a review from a team as a code owner December 4, 2024 23:40
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 4, 2024
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) December 5, 2024 01:13
@fallaciousreasoning fallaciousreasoning merged commit babfcfe into master Dec 5, 2024
19 checks passed
@fallaciousreasoning fallaciousreasoning deleted the settings-close-search branch December 5, 2024 01:29
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 5, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.76

@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2024

Verified with

Brave	1.75.76 Chromium: 132.0.6834.33 (Official Build) nightly (arm64) 
Revision	d1eb5f0ad0eb32f6bc8a8b72e2b6a7b34127706a
OS	macOS Version 15.2 (Build 24C5089c)

Reproduced the issue using STR from brave/brave-browser#42678 and 1.75.72 Chromium: 132.0.6834.15:

72.mov

Using 1.75.76 Chromium: 132.0.6834.33 and same STR confirmed that clicking "x" icon in the settings search bar closes the search bar as expected. Confirmed clicking "x" closes the search bar whether it is empty (no text typed) or if the search bar has text entered in it:

76.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on x on search settings doesn't close the search bar
5 participants