Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI run for contributor PR #26334 #26464

Conversation

brave-builds
Copy link
Collaborator

Description

This PR is created to run CI on the changes proposed in PR #26334 by @jagadeshjai.

This PR should not be merged.

@jagadeshjai
Copy link
Collaborator

@fallaciousreasoning Can you share me the errors from this CI?

@fallaciousreasoning
Copy link
Contributor

fallaciousreasoning commented Nov 11, 2024

@jagadeshjai looks like it was a presubmit failure!
image


[2024-11-10T20:56:51.195Z] + cd src/brave

[2024-11-10T20:56:51.195Z] + npm run presubmit -- --base origin/master

[2024-11-10T20:56:51.195Z] 

[2024-11-10T20:56:51.195Z] > [email protected] presubmit

[2024-11-10T20:56:51.195Z] > node ./build/commands/scripts/commands.js presubmit --base origin/master

[2024-11-10T20:56:51.195Z] 

[2024-11-10T20:56:51.447Z] -------------------------------

[2024-11-10T20:56:51.447Z] /home/ubuntu/workspace/core-build-pr-linux-x64_PR-26464/src/brave

[2024-11-10T20:56:51.447Z] > git config --unset-all gerrit.host

[2024-11-10T20:56:51.447Z] -------------------------------

[2024-11-10T20:56:51.447Z] /home/ubuntu/workspace/core-build-pr-linux-x64_PR-26464/src/brave

[2024-11-10T20:56:51.447Z] > git cl presubmit origin/master --force --upload

[2024-11-10T20:56:52.799Z] Running presubmit upload checks ...

[2024-11-10T20:56:55.296Z]   checking for commit objects in tree took a long time: 0.6s

[2024-11-10T20:56:55.296Z] ** Presubmit ERRORS: 1 **

[2024-11-10T20:56:55.296Z] You added one or more #includes that violate checkdeps rules.

[2024-11-10T20:56:55.296Z]   brave/browser/ui/views/frame/vertical_tab_strip_root_view_browsertest.cc

[2024-11-10T20:56:55.296Z]       Illegal include: "gtest/gtest.h"

[2024-11-10T20:56:55.296Z]     Because of no rule applying.

[2024-11-10T20:56:55.296Z] 

[2024-11-10T20:56:55.296Z] Presubmit checks took 2.6s to calculate.

[2024-11-10T20:56:55.296Z] There were presubmit errors.

[2024-11-10T20:56:55.296Z] Was the presubmit check useful? If not, run "git cl presubmit -v"

[2024-11-10T20:56:55.296Z] to figure out which PRESUBMIT.py was run, then run "git blame"

[2024-11-10T20:56:55.296Z] on the file to figure out who to ask for help.

[2024-11-10T20:56:55.548Z] null

[2024-11-10T20:56:55.548Z] null

I'm pretty sure you already fixed this one, so I've kicked it off again

@github-actions github-actions bot force-pushed the contributor-jagadeshjai-feature__menu_in_vertical_tabs_empty_spaces branch from 89e8cc8 to 3e8fc5b Compare November 11, 2024 19:41
@bsclifton
Copy link
Member

Closing - merged with #26334

@bsclifton bsclifton closed this Nov 11, 2024
@bsclifton bsclifton deleted the contributor-jagadeshjai-feature__menu_in_vertical_tabs_empty_spaces branch November 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants