Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support brave-variations test seed testing process (uplift to 1.67.x) #24650

Closed
wants to merge 1 commit into from
Closed

Support brave-variations test seed testing process (uplift to 1.67.x) #24650

wants to merge 1 commit into from

Conversation

goodov
Copy link
Member

@goodov goodov commented Jul 15, 2024 •
edited
Loading

Uplift of #24604
Resolves brave/brave-browser#39689

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@goodov goodov changed the title Support brave-variations test seed testing process (#24604) Support brave-variations test seed testing process (uplift to 1.67.x) Jul 15, 2024
@goodov goodov force-pushed the pr24604_variations-pull_1.67.x branch from f979263 to b617693 Compare July 15, 2024 13:51
@goodov goodov marked this pull request as ready for review July 17, 2024 06:32
@goodov goodov requested a review from a team as a code owner July 17, 2024 06:32
kjozwiak
kjozwiak reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as the above will be released via 1.68.x next Tuesday via #24627 as discussed via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1720803551601639.

@kjozwiak kjozwiak closed this Jul 17, 2024
@kjozwiak kjozwiak deleted the pr24604_variations-pull_1.67.x branch July 17, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@goodov goodov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodov @kjozwiak