Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong Sync everything initial state on Android (uplift to 1.62.x) #21662

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Fixed wrong Sync everything initial state on Android (uplift to 1.62.x) #21662

merged 1 commit into from
Jan 21, 2024

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jan 20, 2024 •
edited by kjozwiak
Loading

Uplift of #21597
Resolves brave/brave-browser#35333

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner January 20, 2024 09:28
@AlexeyBarabash AlexeyBarabash added this to the 1.62.x - Release milestone Jan 20, 2024
@AlexeyBarabash AlexeyBarabash self-assigned this Jan 20, 2024
kjozwiak
kjozwiak approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly via 1.64.x as per #21597 (comment). The no-platform lint issue was resolved/uplifted into 1.62.x via #21663.

@kjozwiak kjozwiak merged commit 77579a2 into 1.62.x Jan 21, 2024
12 of 13 checks passed
@kjozwiak kjozwiak deleted the pr21597_dont_sync_all_35333_1.62.x branch January 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak