Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uplift 1.62] [Brave News]: Tweaks round 3 (#21393) #21411

Merged
merged 2 commits into from
Dec 20, 2023
Merged

[Uplift 1.62] [Brave News]: Tweaks round 3 (#21393) #21411

merged 2 commits into from
Dec 20, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Dec 18, 2023 •
edited
Loading

Uplift of #21393
Resolves brave/brave-browser#34908

Depends on #21376

@fallaciousreasoning fallaciousreasoning requested a review from a team as a December 18, 2023 00:04
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 18, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.62.x - Beta milestone Dec 19, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly via 1.63.x as per #21393 (comment).

@kjozwiak kjozwiak merged commit a21ef9d into bn-buttons-1.62 Dec 20, 2023
13 checks passed
@kjozwiak kjozwiak deleted the bn-tweaks-round-3-1.62 branch December 20, 2023 20:50
kjozwiak pushed a commit that referenced this pull request Dec 20, 2023
@fallaciousreasoning
[Uplift 1.62] [Brave News]: Improve FeedV2 Buttons (#21347) (#21376)
062747b 
* [Brave News]: Improve FeedV2 Buttons (#21347)

* [Uplift 1.62] [Brave News]: Tweaks round 3 (#21393) (#21411)

* [Brave News]: Tweaks round 3 (#21393)

* [Brave News]: Fix feed load issues on first time use of Brave News (#21410) (#21428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@fallaciousreasoning fallaciousreasoning

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@fallaciousreasoning @brave-builds @kjozwiak