Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Implement AdsObserver #20692

Merged
merged 6 commits into from
Oct 30, 2023
Merged

[ads] Implement AdsObserver #20692

merged 6 commits into from
Oct 30, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 26, 2023

Resolves brave/brave-browser#28726

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm Reminders, brave://rewards, and upgrade browser required (426) are working as expected.

@tmancey tmancey added the CI/skip Do not run CI builds (except noplatform) label Oct 26, 2023
@tmancey tmancey self-assigned this Oct 26, 2023
@tmancey tmancey force-pushed the issues/28726 branch 22 times, most recently from 1c5f373 to 2d79baa Compare October 27, 2023 19:33
@tmancey tmancey removed the CI/skip Do not run CI builds (except noplatform) label Oct 27, 2023
@tmancey tmancey marked this pull request as ready for review October 27, 2023 19:34
@tmancey tmancey requested review from a team as code owners October 27, 2023 19:34
@tmancey tmancey requested a review from zenparsing October 27, 2023 19:49
Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewards 👍


void AdsNotifierManager::AddObserver(
std::unique_ptr<AdsObserverInterface> observer) {
observers_.push_back(std::move(observer));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECK(observer);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will add in a followup.

@tmancey tmancey merged commit fdccd4d into master Oct 30, 2023
@tmancey tmancey deleted the issues/28726 branch October 30, 2023 21:07
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Implement AdsObserver
4 participants