Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented history clearing handler + reset leo confirmation #20179

Merged
merged 11 commits into from
Sep 21, 2023
Merged

implemented history clearing handler + reset leo confirmation #20179

merged 11 commits into from
Sep 21, 2023

Conversation

vadimstruts
Copy link
Collaborator

  • Added checkboxes to clear Brave Leo Assistant for "Advanced" and "On Exit" tabs
  • Implemented common handler for both cases (It is currently doing nothing).
  • Added dialog to confirm when you reset Brave Leo prefs to default

Resolves brave/brave-browser#31441

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • make sure that new checkboxes are visible on the brave://settings/clearBrowserData ("Advanced" and "On Exit" tabs) when you enabled AI-Chat and hidden when disabled
  • make sure that confirmation dialog works properly when you click "Clear Leo data" on the brave://settings/leo-assistant (It means after confirmation: Show Leo icon in the sidebar is ON, Show suggested prompts in the conversation is OFF and AI-Chat icon is shown on the sidebar, otherwise nothing changed)

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 14, 2023
@vadimstruts vadimstruts changed the title 31441 history clearing for brave ai chat implemented history clearing handler + reset leo confirmation Sep 14, 2023
@vadimstruts
Copy link
Collaborator Author

It is a duplicate of the PR: #19504
The original one, has been closed automatically, due to branch messed up on rebase

@vadimstruts vadimstruts mentioned this pull request Sep 14, 2023
Closed
25 tasks
@vadimstruts vadimstruts marked this pull request as ready for review September 14, 2023 23:21
@vadimstruts vadimstruts requested review from a team as code owners September 14, 2023 23:21
fallaciousreasoning
fallaciousreasoning approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

browser/resources/settings/brave_leo_assistant_page/brave_leo_assistant_page.ts Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

SergeyZhukovsky
SergeyZhukovsky approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

mkarolin
mkarolin approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@SergeyZhukovsky SergeyZhukovsky force-pushed the 31441-history-clearing-for-brave-ai-chat branch from 3707fb3 to 52e843f Compare September 19, 2023 18:05
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

vadimstruts and others added 4 commits September 21, 2023 14:48
@vadimstruts @SergeyZhukovsky
added new feature flag 'brave-ai-chat-history', put the ai-chat histo…
f11eb16 
…ry cleaning and related UX behind

Signed-off-by: Vadym Struts <[email protected]>
@vadimstruts @fallaciousreasoning @SergeyZhukovsky
Update browser/resources/settings/brave_leo_assistant_page/brave_leo_…
6d95267 
…assistant_page.ts


applied nit fix

Co-authored-by: Jay Harris <[email protected]>
@vadimstruts @SergeyZhukovsky
fixed build on android
feb1b88 
Signed-off-by: Vadym Struts <[email protected]>
@vadimstruts @SergeyZhukovsky
fixed build & format
2cd7988 
Signed-off-by: Vadym Struts <[email protected]>
@SergeyZhukovsky SergeyZhukovsky force-pushed the 31441-history-clearing-for-brave-ai-chat branch from c6055c4 to 2cd7988 Compare September 21, 2023 18:49
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@vadimstruts
Copy link
Collaborator Author

Merged as got approved by the several devs

@vadimstruts vadimstruts merged commit 3cccec9 into master Sep 21, 2023
5 checks passed
@vadimstruts vadimstruts deleted the 31441-history-clearing-for-brave-ai-chat branch September 21, 2023 21:57
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

@goodov goodov goodov approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@vadimstruts vadimstruts

Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging this pull request may close these issues.

History clearing for Brave AI chat
6 participants
@vadimstruts @brave-builds @goodov @fallaciousreasoning @SergeyZhukovsky @mkarolin