Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text to speech in reader mode added. #19213

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Text to speech in reader mode added. #19213

merged 5 commits into from
Sep 18, 2023

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Jul 10, 2023 •
edited
Loading

Resolves brave/brave-browser#31540

tts.mp4

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@boocmp boocmp requested a review from iefremov as a code owner July 10, 2023 14:02
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 10, 2023
@boocmp boocmp marked this pull request as draft July 10, 2023 14:03
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@boocmp boocmp force-pushed the speedreader-text-to-speech branch from f34438c to 977d7e9 Compare July 11, 2023 03:38
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@iefremov
Copy link
Contributor

still draft?

@boocmp boocmp force-pushed the speedreader-text-to-speech branch from 977d7e9 to 3c9a0da Compare July 26, 2023 14:04
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@boocmp boocmp force-pushed the speedreader-text-to-speech branch from 3c9a0da to 5b77d0f Compare July 27, 2023 10:15
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@boocmp boocmp force-pushed the speedreader-text-to-speech branch from 5b77d0f to 6cd00a8 Compare September 5, 2023 13:17
@boocmp boocmp marked this pull request as ready for review September 5, 2023 13:17
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@boocmp boocmp force-pushed the speedreader-text-to-speech branch from 6cd00a8 to 118650c Compare September 6, 2023 05:58
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@boocmp
Text to speech in reader mode added.
baa54d9
@boocmp
Title reading.
c5142c8
@boocmp
Inline Play/Pause button has been added.
8200c6b 
Voice filter has been added, only voices which support the preferred languages (browser prefs) are listed in the voice control.
@boocmp
Inline Play/Pause button has been added.
33b8e04 
Voice filter has been added, only voices which support the preferred languages (browser prefs) are listed in the voice control.
@boocmp
Added ttsEnabled feature param.
a3b89ea
@boocmp boocmp force-pushed the speedreader-text-to-speech branch from 118650c to a3b89ea Compare September 15, 2023 13:32
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@rebron rebron merged commit a8aeb07 into master Sep 18, 2023
@rebron rebron deleted the speedreader-text-to-speech branch September 18, 2023 17:39
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@iefremov iefremov iefremov approved these changes

Assignees

@thypon thypon

@iefremov iefremov

@goodov goodov

@boocmp boocmp

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build needs-security-review
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging this pull request may close these issues.

Add toolbar for text to speech
6 participants
@boocmp @brave-builds @iefremov @thypon @goodov @rebron