Skip to content

Commit

Permalink
Update strings for iframe scenarios.
Browse files Browse the repository at this point in the history
  • Loading branch information
goodov committed Dec 13, 2024
1 parent fb38358 commit f796bd9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions app/brave_generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -1327,7 +1327,7 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext
<ph name="SITE">$1<ex>http://foo.com</ex></ph> wants to open
</message>
<message name="IDS_BRAVE_FILE_SELECT_OPEN_TITLE_IFRAME" desc="">
An embedded page on <ph name="SITE">$1<ex>http://foo.com</ex></ph> wants to open
An embedded page at <ph name="SITE">$1<ex>http://foo.com</ex></ph> wants to open
</message>
<message name="IDS_BRAVE_FILE_SELECT_OPEN_TITLE_NONSTANDARD_URL" desc="">
This page wants to open
Expand All @@ -1339,7 +1339,7 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext
<ph name="SITE">$1<ex>http://foo.com</ex></ph> wants to save
</message>
<message name="IDS_BRAVE_FILE_SELECT_SAVE_TITLE_IFRAME" desc="">
An embedded page on <ph name="SITE">$1<ex>http://foo.com</ex></ph> wants to save
An embedded page at <ph name="SITE">$1<ex>http://foo.com</ex></ph> wants to save
</message>
<message name="IDS_BRAVE_FILE_SELECT_SAVE_TITLE_NONSTANDARD_URL" desc="">
This page wants to save
Expand Down
12 changes: 6 additions & 6 deletions browser/ui/brave_file_select_utils_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ TEST(BraveFileSelectUtilsUnitTest, GetSiteFrameTitleForFileSelect_Open) {
"foo.com wants to open"},
// Subframe alert from a different origin.
{"subframe different origin", "http://foo.com/", false, "http://bar.com/",
"An embedded page on bar.com wants to open"},
"An embedded page at bar.com wants to open"},

// file:
// - main frame:
Expand Down Expand Up @@ -175,7 +175,7 @@ TEST(BraveFileSelectUtilsUnitTest, GetSiteFrameTitleForFileSelect_Open) {
// - subframe:
{"blob subframe", "http://bar.com/", false,
"blob:http://foo.com/66666666-6666-6666-6666-666666666666",
"An embedded page on foo.com wants to open"},
"An embedded page at foo.com wants to open"},

// filesystem:
// - main frame:
Expand All @@ -184,7 +184,7 @@ TEST(BraveFileSelectUtilsUnitTest, GetSiteFrameTitleForFileSelect_Open) {
// - subframe:
{"filesystem subframe", "http://bar.com/", false,
"filesystem:http://foo.com/bar.html",
"An embedded page on foo.com wants to open"},
"An embedded page at foo.com wants to open"},
};

brave_l10n::test::ScopedDefaultLocale scoped_locale("en-US");
Expand Down Expand Up @@ -230,7 +230,7 @@ TEST(BraveFileSelectUtilsUnitTest, GetSiteFrameTitleForFileSelect_Save) {
"foo.com wants to save"},
// Subframe alert from a different origin.
{"subframe different origin", "http://foo.com/", false, "http://bar.com/",
"An embedded page on bar.com wants to save"},
"An embedded page at bar.com wants to save"},

// file:
// - main frame:
Expand Down Expand Up @@ -278,7 +278,7 @@ TEST(BraveFileSelectUtilsUnitTest, GetSiteFrameTitleForFileSelect_Save) {
// - subframe:
{"blob subframe", "http://bar.com/", false,
"blob:http://foo.com/66666666-6666-6666-6666-666666666666",
"An embedded page on foo.com wants to save"},
"An embedded page at foo.com wants to save"},

// filesystem:
// - main frame:
Expand All @@ -287,7 +287,7 @@ TEST(BraveFileSelectUtilsUnitTest, GetSiteFrameTitleForFileSelect_Save) {
// - subframe:
{"filesystem subframe", "http://bar.com/", false,
"filesystem:http://foo.com/bar.html",
"An embedded page on foo.com wants to save"},
"An embedded page at foo.com wants to save"},
};

brave_l10n::test::ScopedDefaultLocale scoped_locale("en-US");
Expand Down

0 comments on commit f796bd9

Please sign in to comment.