Skip to content

Commit

Permalink
[cr132] //chrome/browser/ui/javascript_dialogs modularised
Browse files Browse the repository at this point in the history
This makes it necessary to declare this target as a dep of
`//brave/browser/ui`.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/b2877940e18b82a911ba18dfca2ea00988f944b6

commit b2877940e18b82a911ba18dfca2ea00988f944b6
Author: Antonio Gomes <[email protected]>
Date:   Tue Oct 15 10:37:05 2024 +0000

    Modularize chrome/browser/ui/javascript_dialogs

    This CL adds to chrome/browser/ui/javascript_dialogs its own BUILD.gn file.
    Given that there is a circular dependency against both //c/b/:b and
    //c/b/ui:ui, an "impl" GN target was added in order to confine the
    circular dependencies. Once the modularization advances, both
    :javascript_dialogs and :impl GN targets should be unified.

    No behavior change expected.

    [email protected]

    Bug: 372506006
  • Loading branch information
cdesouza-chromium committed Oct 23, 2024
1 parent 095ffd1 commit c8a3b44
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions browser/ui/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,7 @@ source_set("ui") {
"//chrome/browser/devtools",
"//chrome/browser/ui/download",
"//chrome/browser/ui/exclusive_access",
"//chrome/browser/ui/javascript_dialogs",
"//chrome/browser/ui/views/bubble",
"//chrome/browser/ui/views/toolbar",
"//components/bookmarks/browser",
Expand Down

0 comments on commit c8a3b44

Please sign in to comment.