Skip to content

Commit

Permalink
speedreader: specify the correct html5ever version
Browse files Browse the repository at this point in the history
kuchikiki v0.8.2-speedreader declared a dependency on
html5ever 0.26, but we actually build against 0.25.1.
Change the declaration here to match what we have
vendored, which works fine in practice.

Bump to v0.8.3-speedreader which declares a dependency
compatible with what we're building against to simpilify
later updates based on the Cargo.toml information.

Resolves brave/brave-browser#35708
  • Loading branch information
rillian committed Feb 9, 2024
1 parent 7d57398 commit bbfd784
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion components/speedreader/rust/lib/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ include = [

[dependencies]
html5ever = "0.25.1"
kuchikiki = "0.8.2"
kuchikiki = { git = "https://github.com/brave/kuchikiki", rev = "2a6926e83f8849f506f3be7a4de2a0196ffb64dc" }
lol_html = "0.3.0"
regex = "1"
serde_json = "1.0.70"
Expand Down
2 changes: 1 addition & 1 deletion components/speedreader/rust/lib/src/readability/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ edition = "2018"
[dependencies]
bitflags = "1.2"
html5ever = "0.25.1"
kuchikiki = "0.8.2"
kuchikiki = { git = "https://github.com/brave/kuchikiki", rev = "2a6926e83f8849f506f3be7a4de2a0196ffb64dc" }
lazy_static = "1.4"
regex = "1"
serde_json = "1.0"
Expand Down
4 changes: 2 additions & 2 deletions third_party/rust/kuchikiki/v0_8/README.chromium
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Name: kuchikiki
URL: https://github.com/brave/kuchikiki/tree/speedreader
Description: (口利き) HTML tree manipulation library
Version: 0.8.2
Version: 0.8.3
Security Critical: yes
Shipped: yes
License: MIT
License File: //brave/third_party/rust/kuchikiki/v0_8/crate/LICENSE
Revision: 436b4e21274e64c5f9bc142ba6fa330fe9a8c97d
Revision: 2a6926e83f8849f506f3be7a4de2a0196ffb64dc
4 changes: 2 additions & 2 deletions third_party/rust/kuchikiki/v0_8/crate/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
[package]
edition = "2018"
name = "kuchikiki"
version = "0.8.2"
version = "0.8.3"
authors = [
"Brave Authors",
"Ralph Giles <[email protected]>",
Expand All @@ -31,7 +31,7 @@ doctest = false
version = "0.27"

[dependencies.html5ever]
version = "0.26.0"
version = "0.25.1"

[dependencies.indexmap]
version = "1.6.0"
Expand Down

0 comments on commit bbfd784

Please sign in to comment.