Code review suggestions fixes

brave · Dec 16, 2024 · 44ce554 · 44ce554
1 parent 42c5569
commit 44ce554
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/...d/java/org/chromium/chrome/browser/media/ui/BraveMediaNotificationControllerDelegate.java b/...d/java/org/chromium/chrome/browser/media/ui/BraveMediaNotificationControllerDelegate.java
@@ -12,11 +12,14 @@
 import android.media.AudioManager;
 
 import org.chromium.base.ContextUtils;
+import org.chromium.base.Log;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.notifications.NotificationConstants;
 
 public class BraveMediaNotificationControllerDelegate
         extends ChromeMediaNotificationControllerDelegate {
+    private static final String TAG = "BraveMediaNotif";
+
     BraveMediaNotificationControllerDelegate(int id) {
         super(id);
         ChromeMediaNotificationControllerDelegate.sMapNotificationIdToOptions.put(
@@ -70,6 +73,11 @@ public void onReceive(Context context, Intent intent) {
                         try {
                             getContext().startService(i);
                         } catch (RuntimeException e) {
+                            Log.e(
+                                    TAG,
+                                    "Can't start "
+                                        + "BraveMediaNotificationControllerServices.PlaybackListenerMicService", // presubmit: ignore-long-line
+                                    e);
                         }
                     }
                 };

diff --git a/...ava/src/org/chromium/components/browser_ui/notifications/BraveForegroundServiceUtils.java b/...ava/src/org/chromium/components/browser_ui/notifications/BraveForegroundServiceUtils.java
@@ -16,8 +16,9 @@ public class BraveForegroundServiceUtils extends ForegroundServiceUtils {
     public void startForeground(
             Service service, int id, Notification notification, int foregroundServiceType) {
         // Check for a service that is dedicated to Brave Talk
-        if (service.getClass().getSimpleName().equals(sBraveTalkServiceClassName)
-                || service.getClass().getSimpleName().endsWith("$" + sBraveTalkServiceClassName)) {
+        String serviceSimpleName = service.getClass().getSimpleName();
+        if (serviceSimpleName.equals(sBraveTalkServiceClassName)
+                || serviceSimpleName.endsWith("$" + sBraveTalkServiceClassName)) {
             foregroundServiceType |= ServiceInfo.FOREGROUND_SERVICE_TYPE_MICROPHONE;
         }
         super.startForeground(service, id, notification, foregroundServiceType);