Skip to content

Commit

Permalink
[cr133] GetOfferForUrl returning a const T*
Browse files Browse the repository at this point in the history
As `BraveIsOfferValid` was taking a multable pointer, the change to a
const pointer caused a build breakage.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/4ee9d87d53be7f3423cc433f769f09f9b33c62af

commit 4ee9d87d53be7f3423cc433f769f09f9b33c62af
Author: Jan Keitel <[email protected]>
Date:   Tue Dec 17 01:19:36 2024 -0800

    Let PayDM::GetAutofillOffers return vector of const pointers.

    As a drive-by, only pass PayDM to the AutofillOfferManager. It does
    not need the full PersonalDataManager.

    Bug: 40100455
  • Loading branch information
cdesouza-chromium committed Dec 19, 2024
1 parent 5465d36 commit 39a6d38
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace {

// This replicates the functionality that the removed upstream flag
// kAutofillEnableOfferNotificationForPromoCodes used to have.
bool BraveIsOfferValid(AutofillOfferData* offer) {
bool BraveIsOfferValid(const AutofillOfferData* offer) {
if (!offer) {
return false;
}
Expand Down

0 comments on commit 39a6d38

Please sign in to comment.