[AI Chat] WebManifest for PWA install

browser/ui/webui/ai_chat/ai_chat_ui.cc

@@ -73,6 +73,8 @@ AIChatUI::AIChatUI(content::WebUI* web_ui)
   webui::SetupWebUIDataSource(source, kAiChatUiGenerated, IDR_AI_CHAT_UI_HTML);
 
   source->AddResourcePath("styles.css", IDR_AI_CHAT_UI_CSS);
+  source->AddResourcePath("manifest.webmanifest", IDR_AI_CHAT_UI_MANIFEST);
+  source->AddResourcePath("pwa_icon.svg", IDR_AI_CHAT_UI_PWA_ICON);
 
   for (const auto& str : ai_chat::GetLocalizedStrings()) {
     source->AddString(str.name,

chromium_src/chrome/browser/banners/app_banner_manager_desktop_browsertest.cc

@@ -0,0 +1,42 @@
+// Copyright (c) 2024 The Brave Authors. All rights reserved.
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at https://mozilla.org/MPL/2.0/.
+
+#include "src/chrome/browser/banners/app_banner_manager_desktop_browsertest.cc"
+
+#include "brave/components/constants/webui_url_constants.h"
+namespace webapps {
+
+class AppBannerManagerDesktopBrowserTestForBraveAllowedPage
+    : public AppBannerManagerDesktopBrowserTest {
+ public:
+  void SetUp() override {
+    scoped_feature_list_.InitWithFeatures(
+        /*enabled_features=*/{}, GetDisabledFeatures());
+    TestAppBannerManagerDesktop::SetUp();
+    AppBannerManagerBrowserTestBase::SetUp();
+  }
+};
+
+IN_PROC_BROWSER_TEST_F(AppBannerManagerDesktopBrowserTestForBraveAllowedPage,
+                       WebUiAIChatApp) {
+  TestAppBannerManagerDesktop* manager =
+      TestAppBannerManagerDesktop::FromWebContents(
+          browser()->tab_strip_model()->GetActiveWebContents());
+
+  // Simulate loading an AI Chat page
+  {
+    base::RunLoop run_loop;
+    manager->PrepareDone(run_loop.QuitClosure());
+
+    ASSERT_TRUE(ui_test_utils::NavigateToURL(
+        browser(), GURL(base::StrCat({"chrome://", kAIChatUIHost}))));
+    run_loop.Run();
+  }
+
+  EXPECT_EQ(InstallableWebAppCheckResult::kYes_Promotable,
+            manager->GetInstallableWebAppCheckResult());
+}
+
+}  // namespace webapps

chromium_src/chrome/browser/web_applications/web_app_helpers.cc

@@ -0,0 +1,23 @@
+// Copyright (c) 2024 The Brave Authors. All rights reserved.
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at https://mozilla.org/MPL/2.0/.
+
+#include "base/containers/contains.h"
+#include "brave/components/constants/webui_url_constants.h"
+
+// Make sure IsValidWebAppUrl also checks for allowed Brave WebUI hosts
+#define IsValidWebAppUrl IsValidWebAppUrl_ChromiumImpl
+
+#include "src/chrome/browser/web_applications/web_app_helpers.cc"
+#undef IsValidWebAppUrl
+
+namespace web_app {
+
+bool IsValidWebAppUrl(const GURL& app_url) {
+  return IsValidWebAppUrl_ChromiumImpl(app_url) ||
+         (app_url.SchemeIs(content::kChromeUIScheme) &&
+          base::Contains(kInstallablePWAWebUIHosts, app_url.host()));
+}
+
+}  // namespace web_app

chromium_src/chrome/browser/web_applications/web_app_helpers_unittest.cc

@@ -0,0 +1,14 @@
+// Copyright (c) 2024 The Brave Authors. All rights reserved.
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at https://mozilla.org/MPL/2.0/.
+
+#include "src/chrome/browser/web_applications/web_app_helpers_unittest.cc"
+
+namespace web_app {
+
+TEST(WebAppHelpers, Brave_IsValidWebAppUrl) {
+  EXPECT_TRUE(IsValidWebAppUrl(GURL("chrome://leo-ai")));
+}
+
+}  // namespace web_app

chromium_src/components/webapps/browser/banners/app_banner_manager.cc

@@ -0,0 +1,19 @@
+// Copyright (c) 2024 The Brave Authors. All rights reserved.
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this file,
+// You can obtain one at https://mozilla.org/MPL/2.0/.
+
+#include "base/containers/contains.h"
+#include "brave/components/constants/webui_url_constants.h"
+
+// Include password_manager constants before override so we don't override the
+// definition.
+#include "components/password_manager/content/common/web_ui_constants.h"
+
+// Add some extra items to WebUI hosts considered valid for PWAs
+#define kChromeUIPasswordManagerHost \
+  kChromeUIPasswordManagerHost &&    \
+      !base::Contains(kInstallablePWAWebUIHosts, url.host())
+
+#include "src/components/webapps/browser/banners/app_banner_manager.cc"
+#undef kChromeUIPasswordManagerHost

components/ai_chat/resources/ai_chat_ui_resources.grdp

@@ -6,4 +6,6 @@
   <include name="IDR_AI_CHAT_UNTRUSTED_CONVERSATION_UI_HTML"
     file="../ai_chat/resources/untrusted_conversation_frame/untrusted_conversation_frame.html"
     type="BINDATA" />
+  <include name="IDR_AI_CHAT_UI_MANIFEST" file="../ai_chat/resources/page/manifest.webmanifest" type="BINDATA" />
+  <include name="IDR_AI_CHAT_UI_PWA_ICON" file="../ai_chat/resources/page/pwa_icon.svg" type="BINDATA" />
 </grit-part>

components/ai_chat/resources/page/ai_chat_ui.html

@@ -15,6 +15,7 @@
     <script src="/strings.js"></script>
     <script src="chat_ui.bundle.js" type="module"></script>
     <link rel="icon" href="//resources/brave-icons/social-leo-favicon-fullheight-color.svg">
+    <link rel="manifest" href="manifest.webmanifest">
     <style>
       @media (prefers-color-scheme: dark) {
         body {

components/ai_chat/resources/page/manifest.webmanifest

@@ -0,0 +1,15 @@
+{
+  "short_name": "$i18n{siteTitle}",
+  "name": "$i18n{siteTitle}",
+  "icons": [
+    {
+      "src": "/pwa_icon.svg",
+      "type": "image/svg+xml",
+      "sizes": "any"
+    }
+  ],
+  "start_url": "/?source=pwa",
+  "id": "chrome://leo-ai/",
+  "display": "standalone",
+  "scope": "chrome://leo-ai/"
+}

components/constants/webui_url_constants.h

@@ -6,6 +6,9 @@
 #ifndef BRAVE_COMPONENTS_CONSTANTS_WEBUI_URL_CONSTANTS_H_
 #define BRAVE_COMPONENTS_CONSTANTS_WEBUI_URL_CONSTANTS_H_
 
+#include <string_view>
+
+#include "base/containers/fixed_flat_set.h"
 #include "build/build_config.h"
 
 inline constexpr char kAdblockHost[] = "adblock";
@@ -92,4 +95,12 @@ inline constexpr char kRewriterUIHost[] = "rewriter";
 inline constexpr char16_t kTransactionSimulationLearnMoreURL[] =
     u"https://github.com/brave/brave-browser/wiki/Transaction-Simulation";
 
+// Hosts that are allowed to be installed as PWAs, which is usually
+// a blocked action for WebUIs. In Chromium, the "password-manager" host
+// is already allowed.
+inline constexpr auto kInstallablePWAWebUIHosts =
+    base::MakeFixedFlatSet<std::string_view>({
+        kAIChatUIHost,
+    });
+
 #endif  // BRAVE_COMPONENTS_CONSTANTS_WEBUI_URL_CONSTANTS_H_

components/resources/ai_chat_ui_strings.grdp

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <grit-part>
   <message name="IDS_CHAT_UI_TITLE" translateable="false" desc="Title for the Brave AI product">
-    Leo
+    Leo AI
   </message>
   <message name="IDS_CHAT_UI_SUMMARIZE_FAILED_LABEL" desc="Label for when summarization is not possible">
     The summarizer feature is currently available only for select articles and other long-form web pages.