Skip to content

Commit

Permalink
[cr132][DanglingPtr] ComponentInstallerPolicy overstaying
Browse files Browse the repository at this point in the history
`ComponentInstallerPolicy` instances are supposed to die during tests
with `ComponentUpdateService`. However as `SequentialUpdateChecker` was
taking references to these shared data, this was keeping the policies
alive indefinetely, which was causing dangling pointer crashes in CI.

This change temporarily filters these tests in particular:

ComponentManagerUpdateCheckBrowserTest.RegisterAndUnregisterTranslateKitLanguagePackComponent
ComponentManagerUpdateCheckBrowserTest.RegisterTranslateKitComponent

We will fix this properly in a subsequent commit via
brave/brave-browser#42532.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/fa904be21056bca3dfa3e46a031af1e6787aef67

commit fa904be21056bca3dfa3e46a031af1e6787aef67
Author: Tsuyoshi Horo <[email protected]>
Date:   Thu Oct 24 09:27:34 2024 +0000

    Add a simple browser_test for Translator API.

    This CL introduces a new ComponentManager class which handles the
    TranslateKit component and the language pack components.
    And also this CL adds a simple browser test for Translator API by
    using a fake ComponentManager which can install a mock_translate_kit_lib
    and a fake language pack.

    Bug: 374631433
  • Loading branch information
emerick authored and cdesouza-chromium committed Nov 29, 2024
1 parent 7b066ed commit 1b46186
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions test/filters/browser_tests.filter
Original file line number Diff line number Diff line change
Expand Up @@ -1931,6 +1931,11 @@
# This test fails because we stub out NetworkService::UpdateKeysPinList
-PKIMetadataComponentInstallerTest.InstallComponentUpdatesPinningConfig

# Temporarily disabled due to a dangling pointer issue in our update checker,
# identified here https://github.com/brave/brave-browser/issues/42532
-ComponentManagerUpdateCheckBrowserTest.RegisterAndUnregisterTranslateKitLanguagePackComponent
-ComponentManagerUpdateCheckBrowserTest.RegisterTranslateKitComponent

# Tests below this point have not been diagnosed or had issues created yet.
-_/WebrtcLoggingPrivateApiStartEventLoggingTestFeatureAndPolicyEnabled.*
-AccessCodeCastHandlerBrowserTest.*
Expand Down

0 comments on commit 1b46186

Please sign in to comment.