Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove animation for Open YT dialog #42864

Closed
deeppandya opened this issue Dec 12, 2024 · 1 comment · Fixed by brave/brave-core#27000
Closed

Remove animation for Open YT dialog #42864

deeppandya opened this issue Dec 12, 2024 · 1 comment · Fixed by brave/brave-core#27000
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.75.x - Nightly

Comments

@deeppandya
Copy link

In this issue, we need to remove lottie animation and replace it with an svg image.
@deeppandya deeppandya added OS/Android Fixes related to Android browser functionality QA/Yes release-notes/exclude labels Dec 12, 2024
@deeppandya deeppandya self-assigned this Dec 12, 2024
@deeppandya deeppandya mentioned this issue Dec 12, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 18, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 20, 2024
@hffvld
Copy link
Contributor

hffvld commented Dec 20, 2024

Verified on Galaxy Z Fold 6 using version(s):

Device/OS: Galaxy Z Fold 6 / q6quew-user 14 UP1A.231005.007 release-keys
Brave build: 1.75.111
Chromium: 132.0.6834.46 (Official Build) canary (64-bit)

STEPS:

  1. Follow the STR/TP from Open youtube in brave android brave-core#26595 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that animation is removed from the YT modal and replaced with the static SVG image.
  • Verified that tapping Turn on now opens the YT website and Open YouTube links in Brave toggle switch in Settings > Media got enabled.
  • Verified that tapping No, thank you doesn't open the YT website and Open YouTube links in Brave toggle switch in Settings > Media is not enabled.
1 2
1 2
2024-12-19_17-01-07.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.75.x - Nightly
Development

Successfully merging a pull request may close this issue.

Remove animations open yt dialog brave/brave-core
3 participants
@deeppandya @brave-builds @hffvld