Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on x on search settings doesn't close the search bar #42678

Closed
2 of 6 tasks
GeetaSarvadnya opened this issue Dec 4, 2024 · 6 comments · Fixed by brave/brave-core#26874
Closed
2 of 6 tasks

Click on x on search settings doesn't close the search bar #42678

GeetaSarvadnya opened this issue Dec 4, 2024 · 6 comments · Fixed by brave/brave-core#26874
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.74.x - Beta

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 4, 2024 •
edited
Loading

Description

Click on x on search download history bar doesn't close the search bar

Steps to reproduce

  1. Clean profile 1.74.x OR 1.75.66 CR131 OR 1.75.69 CR132
  2. Open brave://downloads
  3. Click on Search icon
  4. Click on x button search bar is not closed

Actual result

Click on x on search download history bar doesn't close the search bar
Image

Expected result

Click on x should close the search download history bar

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.75.69 Chromium: 132.0.6834.15 (Official Build) nightly (64-bit)
Revision deb39c780c5ec5570f05476b4ebd60748abd3d23
OS Windows 10 Version 22H2 (Build 19045.5131)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @emerick @rebron
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Dec 4, 2024
Closed
@GeetaSarvadnya
Copy link
Author

cc: @aguscruiz

@GeetaSarvadnya GeetaSarvadnya changed the title Click on x on search download history bar doesn't close the search bar Click on x on search settings doesn't close the search bar Dec 4, 2024
@GeetaSarvadnya
Copy link
Author

@aguscruiz : Looks like this issue is happening for all the header settings search, not only for downloads. This is a regression issue work fine on 1.73.x but broken on 1.74.x.

Image

cc: @rebron

@emerick
Copy link
Contributor

emerick commented Dec 4, 2024

Strangely enough, right clicking it closes it (which probably shouldn't happen). cc: @fallaciousreasoning

@fallaciousreasoning fallaciousreasoning mentioned this issue Dec 4, 2024
Merged
24 tasks
@fallaciousreasoning
Copy link

I think the reason right click closes it is because it closes on blur

@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 5, 2024
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 5, 2024
@rebron rebron moved this to Completed in Settings Dec 5, 2024
@brave-builds brave-builds mentioned this issue Dec 5, 2024
Merged
7 tasks
@LaurenWags
Copy link
Member

Requires 1.74.21 or higher for verification 👍🏻

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.74.24 Chromium: 132.0.6834.33 (Official Build) beta (64-bit)
-- | --
Revision | 3f746b728dd340e7d438b026bddf72f4001c1088
OS | Windows 11 Version 24H2 (Build 26100.2314)

Verified using STR from #42678 (comment)

Confirmed when clicked on x, search download history bar and others closed as expected.

2024-12-10_13h38_05.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
Settings
Status: Completed
Milestone
1.74.x - Beta
Development

Successfully merging a pull request may close this issue.

[Toolbar]: Fix close search button brave/brave-core
7 participants
@emerick @rebron @fallaciousreasoning @LaurenWags @GeetaSarvadnya @brave-builds @MadhaviSeelam