kuchikiki version inconsistencies #35708
Assignees
Labels
dev-concern
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA/No
release-notes/exclude
Milestone
Comments
rillian
added
dev-concern
OS/Android
rillian
added a commit
to brave/brave-core
that referenced
this issue
Jan 31, 2024
kuchikiki v0.8.2-speedreader declared a dependency on html5ever 0.26, but we actually build against 0.25.1. Change the declaration here to match what we have vendored, which works fine in practice. Bump to v0.8.3-speedreader which declares a dependency compatible with what we're building against to simpilify later updates based on the Cargo.toml information. Resolves brave/brave-browser#35708
24 tasks
rillian
added a commit
to brave/brave-core
that referenced
this issue
Feb 9, 2024
kuchikiki v0.8.2-speedreader declared a dependency on html5ever 0.26, but we actually build against 0.25.1. Change the declaration here to match what we have vendored, which works fine in practice. Bump to v0.8.3-speedreader which declares a dependency compatible with what we're building against to simpilify later updates based on the Cargo.toml information. Resolves brave/brave-browser#35708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Follow-up to brave/brave-core#18488
There are some inconsistencies between Cargo.toml, BUILD.gn, and Cargo.lock. Aligning these will simplify brave/brave-core#21759
The text was updated successfully, but these errors were encountered: